Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realtek-RTL8195AM-Hide_Debugging_Messages #9202

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Realtek-RTL8195AM-Hide_Debugging_Messages #9202

merged 1 commit into from
Jan 3, 2019

Conversation

AdamZhang0124
Copy link
Contributor

This PR addresses the issue of #8903.
A new boolean variable 'debug' is added to turn off the display of debugging message (by default). It can be turned on when needed.

Description

  1. Add new boolean parameter ‘debug’ in function ‘RTWInterface’ in file "RTWInterface.h".
  2. Add conditional statement to enable/disable variable ‘GlobalDebugEnable’ in file "RTWInterface.h" to control whether debugging message should be displayed.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AdamZhang0124
realtek-rtl8195am-Hide_Debugging_Messages
5fa1273 
This PR addresses the issue of ARMmbed#8903.
A new boolean variable 'debug' is added to turn off the display of debugging message (by default). It can be turned on when needed.

Description
1.	Add new boolean parameter ‘debug’ in function ‘RTWInterface’ in file "RTWInterface.h".
2.	Add conditional statement to enable/disable variable ‘GlobalDebugEnable’ in file "RTWInterface.h" to control whether debugging message should be displayed.
@AdamZhang0124 AdamZhang0124 mentioned this pull request Dec 27, 2018
Closed
@ciarmcom ciarmcom requested a review from a team December 27, 2018 08:00
@ciarmcom
Copy link
Member

@AdamZhang0124, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Dec 27, 2018

@MarceloSalazar @screamerbg @ashok-rao Do we have a precedent with partners supplying their own debug symbols?

@AdamZhang0124 I'm fine with the fix, but considering that Mbed OS has it's own debug symbols, I'm wondering if those should be used instead. No change on your side is required yet.

@AdamZhang0124
Copy link
Contributor Author

Hi @cmonr ,
Happy new year!
Thanks for the feedback. I am looking forward to your reply so that this issue can be closed as soon as possible.

0xc0170
0xc0170 approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various drivers use bool debug parameter as well, should be good

@cmonr
Copy link
Contributor

cmonr commented Jan 3, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 3, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 3, 2019

There is a device problem, we will restart tests once this is resolved (thus the job was aborted)

@AdamZhang0124
Copy link
Contributor Author

@0xc0170 ,
Noted with thanks.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 3, 2019

CI restarted

@cmonr cmonr merged commit f8375a4 into ARMmbed:master Jan 3, 2019
@0xc0170 0xc0170 mentioned this pull request Jan 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdamZhang0124 @ciarmcom @cmonr @mbed-ci @0xc0170