Add GD32_E103VB as new target #9203

ChazJin · 2018-12-27T09:57:19Z

Description

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

CC @Ronny-Liu @0xc0170 @ashok-rao please review when you're available, many thanks!

ciarmcom · 2018-12-27T10:00:26Z

@ChazJin, thank you for your changes.
@ashok-rao @0xc0170 @Ronny-Liu@ARMmbed/mbed-os-maintainers please review.

ChazJin · 2018-12-27T10:09:59Z

The test results based on MBED OS 5.11 are as follows(WIN10, run "mbed test -t GCC_ARM/ARM/IAR -m GD32_E103VB" directly).

GD32E103VB_ARM_5_11.txt
GD32E103VB_IAR_5_11.txt
GD32E103VB_GCC_ARM_5_11.txt

0xc0170 · 2019-01-02T12:23:49Z

Merge branch 'master' into gd32e10x

Is this merging latest master changes to your branch? Can this be eliminated by doing rebase?

0xc0170

Waiting for master merge commit (otherwise code looks fine to me)

ChazJin · 2019-01-02T12:46:09Z

Merge branch 'master' into gd32e10x

Is this merging latest master changes to your branch? Can this be eliminated by doing rebase?

I resolve the conflict directly on the web, and I think this should be the latest master change. If you don't think it's appropriate, I'll try ‘git reset’ this commit and rebase it. Is that right? Thanks! @0xc0170

0xc0170 · 2019-01-02T12:47:29Z

Please do, the web interface is not ideal in this case and rather resolve this locally

ChazJin · 2019-01-03T10:11:47Z

Please do, the web interface is not ideal in this case and rather resolve this locally

I have rebase it and resolve this locally. However, it seems that some error happens which leads to the Travis CI build could not complete in continuous-integration/travis-ci/pr. I would appreciate it if you could give me a few pointer. @0xc0170

0xc0170 · 2019-01-03T11:01:51Z

This was travis error, restarted it

0xc0170 · 2019-01-03T13:56:58Z

Waiting for @ashok-rao to review and/or @Ronny-Liu

Ronny-Liu

Should the device folder be outside of TARGET_GD32E103VB? There are GD32E1xx common file in the device folder.

0xc0170 · 2019-01-08T09:36:24Z

Ci started

cmonr · 2019-01-10T20:46:41Z

Restarting jenkins-ci/exporter job.

Windows node closed its connection too soon.

ChazJin · 2019-01-11T02:11:52Z

Restarting jenkins-ci/exporter job.

Windows node closed its connection too soon.

Hi @cmonr, I found there is a conflicting file(target.json), I have resolved it and force-pushed gd32e10x branch which means CI test may be re-executed. Sorry for the trouble you've taken.

cmonr · 2019-01-11T02:49:01Z

@ChazJin Wow, what timing!
I had just finished doing the rebase on my side and was about to push to get this into CI tonight, thanks!

Commits look good, although I'm puzzled why Travis CI hasn't started. Will start CI once Travis has started and passed.

cmonr · 2019-01-11T02:49:34Z

Trying a thing.

cmonr · 2019-01-11T02:51:18Z

Aaand Travis CI picked that up!

...it's been having issues lately...

cmonr · 2019-01-11T03:43:41Z

CI started

mbed-ci · 2019-01-11T04:34:07Z

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM

cmonr · 2019-01-11T05:48:18Z

NOTICE

This PR is on hold because an issue in the master branch was found when this was rebased.
Once the issue is fixed, this PR will need to be rebased, and will immediately enter CI.

mprse · 2019-01-11T09:06:00Z

NOTICE
This PR is on hold because an issue in the master branch was found when this was rebased.
Once the issue is fixed, this PR will need to be rebased, and will immediately enter CI.

PR which adds boot/isr stack size configuration option and unifies boot/isr stack size (PR #9092) has been merged after GD32_F450ZI target has been added (PR #9232).
This caused the CI build failures on GD32_F450ZI/ARM (ARM_LIB_STACK symbol is now reqired ).

I have adapted linker scripts of the new target(GD32_F450ZI) in PR #9350. This should fix the CI issue.

Please adapt linker scripts in this PR. As a reference what has changed you can check PR #8039 which provides framework for configuring boot stack size and example update of the linker scripts.

mprse

Linker scripts looks good!

ChazJin · 2019-01-11T10:13:49Z

NOTICE
This PR is on hold because an issue in the master branch was found when this was rebased.
Once the issue is fixed, this PR will need to be rebased, and will immediately enter CI.

PR which adds boot/isr stack size configuration option and unifies boot/isr stack size (PR #9092) has been merged after GD32_F450ZI target has been added (PR #9232).
This caused the CI build failures on GD32_F450ZI/ARM (ARM_LIB_STACK symbol is now reqired ).

I have adapted linker scripts of the new target(GD32_F450ZI) in PR #9350. This should fix the CI issue.

Please adapt linker scripts in this PR. As a reference what has changed you can check PR #8039 which provides framework for configuring boot stack size and example update of the linker scripts.

Thank you very much. I just adapt linker scripts which refers to your revision and if there are any problems, please point them out. Thanks again for your support. @mprse

0xc0170 · 2019-01-11T14:00:22Z

CI started

mbed-ci · 2019-01-11T22:14:23Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

ciarmcom requested review from 0xc0170, ashok-rao, Ronny-Liu and a team December 27, 2018 10:00

ciarmcom added the needs: review label Dec 27, 2018

ChazJin mentioned this pull request Dec 28, 2018

Add support for GD32_E103VB #9199

Closed

0xc0170 added the scope: new-target label Jan 2, 2019

0xc0170 approved these changes Jan 2, 2019

View reviewed changes

0xc0170 requested changes Jan 2, 2019

View reviewed changes

cmonr added needs: work and removed needs: review labels Jan 3, 2019

ChazJin force-pushed the gd32e10x branch from acc8f3d to a34ebfa Compare January 3, 2019 07:58

0xc0170 approved these changes Jan 3, 2019

View reviewed changes

0xc0170 added needs: review and removed needs: work labels Jan 3, 2019

Ronny-Liu approved these changes Jan 7, 2019

View reviewed changes

0xc0170 added needs: CI release-version: 5.11.2 and removed needs: review labels Jan 7, 2019

Ronny-Liu suggested changes Jan 8, 2019

View reviewed changes

Ronny-Liu approved these changes Jan 8, 2019

View reviewed changes

ChazJin added 2 commits January 11, 2019 09:44

Add GD32_E10X as new target

c9ec363

resolve conflicting file targets.json and add support for GD32_E103VB

7a29b20

ChazJin force-pushed the gd32e10x branch from 4b37352 to 75d4705 Compare January 11, 2019 01:54

adjust directory structure for device

75d4705

cmonr closed this Jan 11, 2019

cmonr removed the needs: CI label Jan 11, 2019

cmonr reopened this Jan 11, 2019

cmonr added the needs: CI label Jan 11, 2019

Support boot stack size configuration option

4d9c434

mprse approved these changes Jan 11, 2019

View reviewed changes

NirSonnenschein added ready for merge and removed needs: CI labels Jan 13, 2019

0xc0170 merged commit f4aaebd into ARMmbed:master Jan 14, 2019

0xc0170 removed the ready for merge label Jan 14, 2019

adbridge added Manually Patch release-version: 5.11.2 and removed release-version: 5.11.2 Manually Patch labels Jan 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GD32_E103VB as new target #9203

Add GD32_E103VB as new target #9203

ChazJin commented Dec 27, 2018

ciarmcom commented Dec 27, 2018

ChazJin commented Dec 27, 2018 •

edited

Loading

0xc0170 commented Jan 2, 2019

0xc0170 left a comment

ChazJin commented Jan 2, 2019

0xc0170 commented Jan 2, 2019

ChazJin commented Jan 3, 2019

0xc0170 commented Jan 3, 2019

0xc0170 commented Jan 3, 2019 •

edited

Loading

Ronny-Liu left a comment

0xc0170 commented Jan 8, 2019

cmonr commented Jan 10, 2019

ChazJin commented Jan 11, 2019

cmonr commented Jan 11, 2019

cmonr commented Jan 11, 2019

cmonr commented Jan 11, 2019

cmonr commented Jan 11, 2019

mbed-ci commented Jan 11, 2019

cmonr commented Jan 11, 2019

mprse commented Jan 11, 2019

mprse left a comment

ChazJin commented Jan 11, 2019

0xc0170 commented Jan 11, 2019

mbed-ci commented Jan 11, 2019

Add GD32_E103VB as new target #9203

Add GD32_E103VB as new target #9203

Conversation

ChazJin commented Dec 27, 2018

Description

Pull request type

Reviewers

ciarmcom commented Dec 27, 2018

ChazJin commented Dec 27, 2018 • edited Loading

0xc0170 commented Jan 2, 2019

0xc0170 left a comment

Choose a reason for hiding this comment

ChazJin commented Jan 2, 2019

0xc0170 commented Jan 2, 2019

ChazJin commented Jan 3, 2019

0xc0170 commented Jan 3, 2019

0xc0170 commented Jan 3, 2019 • edited Loading

Ronny-Liu left a comment

Choose a reason for hiding this comment

0xc0170 commented Jan 8, 2019

cmonr commented Jan 10, 2019

ChazJin commented Jan 11, 2019

cmonr commented Jan 11, 2019

cmonr commented Jan 11, 2019

cmonr commented Jan 11, 2019

cmonr commented Jan 11, 2019

mbed-ci commented Jan 11, 2019

Test run: FAILED

cmonr commented Jan 11, 2019

NOTICE

mprse commented Jan 11, 2019

mprse left a comment

Choose a reason for hiding this comment

ChazJin commented Jan 11, 2019

0xc0170 commented Jan 11, 2019

mbed-ci commented Jan 11, 2019

Test run: SUCCESS

ChazJin commented Dec 27, 2018 •

edited

Loading

0xc0170 commented Jan 3, 2019 •

edited

Loading