Direct access to device key #9215

offirko · 2018-12-31T15:27:15Z

Description

Low code size tool that provides direct access to ROT Device Key
(to be used by BootLoader).

Pending on #9237

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

offirko · 2018-12-31T15:28:03Z

@cmonr , @0xc0170 , @ARMmbed/mbed-os-storage - Please review

ciarmcom · 2018-12-31T16:00:27Z

@offirko, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

0xc0170

Also git log might be cleaned up (reduced to few c ommits for 3 new files).

0xc0170 · 2019-01-02T11:38:19Z

features/storage/kvstore/tdbstore/DirectAccessDevicekey.h

+#include "FlashIAP.h"
+#include <stdio.h>
+
+int direct_access_to_devicekey(uint32_t tdb_start_offset, uint32_t tdb_end_offset, void *data_buf,


is this missing doxygen ?

sorry, I added doxygen info - and squashed the log

Thanks, looks better. But still can be improved: "inital version" - what initial version is it? what does it bring? or successfully compiled ?

@0xc0170 - I'm not sure I follow.. git is source control. Part of its use is to track the different development stages (e.g. enabling quick recovery milestones..) . I agree that sometimes there are too many unimportant stages that can be squashed .. but in general I don't think we should rewrite git-log history prior to delivery or make it look better)..

I partly agree but my point was that this feels like development branch rather than ready for the release. Don't need to squash but rather add details important for users.
Two commits msg have zero value without studying changes and this is functionality change, we should introduce it - why are we bringing this functionality change.

Thanks, I think I now understand what you meant - I'll add the required information.

cmonr · 2019-01-03T02:21:39Z

Fixes #9196

offirko · 2019-01-03T15:40:12Z

Pending on #9237

bulislaw · 2019-01-03T18:19:31Z

Does it need change to design docs and storage documentation? It's hard to see how it fits in the architecture.

dannybenor · 2019-01-03T18:43:31Z

This code will not be documented. Is for the use of the PDMC bootloader, to reduce the size and avoid linking the full TDBStore. In 2 versions, the bootloader will completely change to a PSA oriented, and this code will not be relevant.

cmonr · 2019-01-04T02:50:04Z

#9215 (comment)

Fyi @ARMmbed/mbed-docs @ARMmbed/mbed-os-maintainers
Imo, this sounds reasonable.

0xc0170 · 2019-01-04T10:20:07Z

Version based on prceeding PR

offirko · 2019-01-07T07:54:56Z

@davidsaada - can you please review - Thanks

davidsaada

Looks good, except for a few minor issues.

davidsaada · 2019-01-07T13:29:33Z

features/storage/kvstore/tdbstore/DirectAccessDevicekey.cpp

+exit_point:
+    if (true == is_flash_init) {
+        flash.deinit();
+        is_flash_init = false;


Can remove this line.

davidsaada · 2019-01-07T13:33:26Z

features/storage/kvstore/tdbstore/DirectAccessDevicekey.cpp

+        *out_tdb_start_offset =  MBED_CONF_STORAGE_TDB_EXTERNAL_INTERNAL_BASE_ADDRESS;
+        tdb_size = MBED_CONF_STORAGE_TDB_EXTERNAL_RBP_INTERNAL_SIZE;
+    } else {
+        return MBED_ERROR_UNSUPPORTED;


Should deinit flash here and on next failures.

my bad, some of the ifs are later addition to the code. I will move flash init below them.

davidsaada · 2019-01-07T13:34:57Z

features/storage/kvstore/tdbstore/DirectAccessDevicekey.cpp

+static int reserved_data_get(FlashIAP *flash, tdbstore_area_data_t *area_params, void *reserved_data_buf,
+                             size_t reserved_data_buf_size, size_t *actual_data_size_ptr)
+{
+    int status = MBED_SUCCESS;;


redundant semicolon.

0xc0170 · 2019-01-08T12:03:44Z

Ready for CI as soon as reviewers approve (@davidsaada )

davidsaada

Looks good now.

0xc0170 · 2019-01-08T14:53:17Z

CI started

mbed-ci · 2019-01-08T16:32:40Z

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR

yossi2le · 2019-01-08T16:55:22Z

I have changed the test main file to skip compiling if there is no component flashiap set for the target. I hope this will solve all the build failure.
Can you please run the CI again?
Thanks

offirko · 2019-01-09T08:17:41Z

@yossi2le - thanks for the fix!
@0xc0170 - travis failure doesnt seem to be related - can u pls rerun.

NirSonnenschein · 2019-01-09T10:48:58Z

Hi @offirko,
The Travis failures are caused by an issue fixed on master a few hours ago, and this change should be propagated here via rebase. We can start CI only after travis is fixed, could you please rebase this PR?
Sorry for the trouble

This enables application with code size restrictions to access devicekey directly based on address in internal flash without kvconfig overhead

…e position. (Supporting FILESYSTEM and TDB_EXTERNAL configuration only)

…ent flashiap block device in the target

0xc0170 · 2019-01-09T14:38:30Z

CI started

mbed-ci · 2019-01-10T03:06:39Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

offirko changed the title ~~Offir bootloader direct access to device key~~ Direct access to device key Dec 31, 2018

ciarmcom requested review from a team December 31, 2018 16:00

ciarmcom added the needs: review label Dec 31, 2018

0xc0170 requested changes Jan 2, 2019

View reviewed changes

offirko force-pushed the offir_bootloader_get-device-key branch from d12cab6 to 6bd13b6 Compare January 2, 2019 12:50

cmonr mentioned this pull request Jan 3, 2019

ESP8266 CTS/RTS fails in stop_uart_hw_flow_ctrl() #9196

Closed

offirko force-pushed the offir_bootloader_get-device-key branch from 6bd13b6 to e14b6b7 Compare January 3, 2019 13:09

cmonr added the needs: preceding PR label Jan 3, 2019

0xc0170 added the release-version: 5.11.2 label Jan 4, 2019

0xc0170 requested a review from AnotherButler January 4, 2019 14:34

0xc0170 approved these changes Jan 4, 2019

View reviewed changes

davidsaada suggested changes Jan 7, 2019

View reviewed changes

offirko force-pushed the offir_bootloader_get-device-key branch from 9f73cae to 3c5c098 Compare January 7, 2019 13:51

0xc0170 removed the needs: preceding PR label Jan 8, 2019

davidsaada approved these changes Jan 8, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Jan 8, 2019

offirko and others added 4 commits January 9, 2019 13:48

Adding low code size tool for direct access to Devicekey.

9455793

This enables application with code size restrictions to access devicekey directly based on address in internal flash without kvconfig overhead

Updated test to consider tdb_internal non default configuration as well

bb0d1af

Added utility function to help locate expected internal flash tdbstor…

6592e85

…e position. (Supporting FILESYSTEM and TDB_EXTERNAL configuration only)

The direct_access_devicekey test should not run if there is no compon…

423c4fb

…ent flashiap block device in the target

offirko force-pushed the offir_bootloader_get-device-key branch from e0eea8e to 423c4fb Compare January 9, 2019 11:49

cmonr added ready for merge and removed needs: CI labels Jan 10, 2019

cmonr merged commit d6c014c into ARMmbed:master Jan 10, 2019

cmonr removed the ready for merge label Jan 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Direct access to device key #9215

Direct access to device key #9215

offirko commented Dec 31, 2018 •

edited

Loading

offirko commented Dec 31, 2018

ciarmcom commented Dec 31, 2018

0xc0170 left a comment

0xc0170 Jan 2, 2019

offirko Jan 2, 2019

0xc0170 Jan 2, 2019

offirko Jan 2, 2019 •

edited

Loading

0xc0170 Jan 3, 2019

offirko Jan 3, 2019

cmonr commented Jan 3, 2019 •

edited

Loading

offirko commented Jan 3, 2019

bulislaw commented Jan 3, 2019

dannybenor commented Jan 3, 2019

cmonr commented Jan 4, 2019

0xc0170 commented Jan 4, 2019

offirko commented Jan 7, 2019

davidsaada left a comment

davidsaada Jan 7, 2019

davidsaada Jan 7, 2019

offirko Jan 7, 2019

davidsaada Jan 7, 2019

0xc0170 commented Jan 8, 2019

davidsaada left a comment

0xc0170 commented Jan 8, 2019

mbed-ci commented Jan 8, 2019

yossi2le commented Jan 8, 2019

offirko commented Jan 9, 2019

NirSonnenschein commented Jan 9, 2019

0xc0170 commented Jan 9, 2019

mbed-ci commented Jan 10, 2019

Direct access to device key #9215

Direct access to device key #9215

Conversation

offirko commented Dec 31, 2018 • edited Loading

Description

Pull request type

offirko commented Dec 31, 2018

ciarmcom commented Dec 31, 2018

0xc0170 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

offirko Jan 2, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmonr commented Jan 3, 2019 • edited Loading

offirko commented Jan 3, 2019

bulislaw commented Jan 3, 2019

dannybenor commented Jan 3, 2019

cmonr commented Jan 4, 2019

0xc0170 commented Jan 4, 2019

offirko commented Jan 7, 2019

davidsaada left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xc0170 commented Jan 8, 2019

davidsaada left a comment

Choose a reason for hiding this comment

0xc0170 commented Jan 8, 2019

mbed-ci commented Jan 8, 2019

yossi2le commented Jan 8, 2019

offirko commented Jan 9, 2019

NirSonnenschein commented Jan 9, 2019

0xc0170 commented Jan 9, 2019

mbed-ci commented Jan 10, 2019

offirko commented Dec 31, 2018 •

edited

Loading

offirko Jan 2, 2019 •

edited

Loading

cmonr commented Jan 3, 2019 •

edited

Loading