Release candidate for mbed-os-5.11.3 #9508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
Additionally to internal bookkeeping lets check from the modem that what is connection state in disconnect. There might be inconsistencies.
Currently tests
- drivers
- platform
- rtos
- events
- features/netsocket
…cher. Initialization of Timeout object contains critical section inside constructor. Initialization inside critical section caused assertion failing under "debug" profile.
…-existence checkup if compile for target TFM
…t_access_devicekey sub folder For TFM support
…t as BYPASS_NVSTORE_CHECK
Adjusting the tests to match the cellular modems ELS61-E2 and BGS2-W requirements.
….changes Not sure why mbed_sleep_manager.c was in hal, moving it to platform
File was moved from hal -> platform folder, hence includes should be changed accordingly.
This is for OS2 testing. Previously, targets that were configured with the option "default_toolchain": "uARM" would still build to a TOOLCHAIN_ARM_STD directory. This fixes these targets to build into TOOLCHAIN_ARM_MICRO.
With TCP it's desirable that SIGIO wakes up the application to check if there is buffer space space available on the mode. With UDP the behavior is not acceptable as we don't know if the other endpoint is there as connection establishment is missing. Hence buffers might stay full forever.
Technical author review
Fix the following build warning found when building with ARMC6 toolchain for NRF52_DK with mbed cli version 1.8.3 [Warning] thread_mle_message_handler.c@762,0: #188-D: enumerated type mixed with another type [Warning] thread_mle_message_handler.c@834,0: #188-D: enumerated type mixed with another type
The GenericSecurityManager tracks the most recent OOB data generated by the PAL and the PAL function to generate OOB data is expected to be asynchronous such that the OOB data is returned via a callback. There was a race condition on the security manager's oob data variable because it was cleared (set to all zeros) after calling PAL generate. The expectation was that the clear operation would occur before the callback executed, but this is proving to not be the case. Instead, the callback is being executed as if it were syncronous with PAL generate, then PAL generate returns and the oob data is cleared, thereby losing the generated oob data that was set in the callback. To fix the issue, clear the oob data variables before calling into the PAL.
The function in the Nordic SDK for generating OOB data,
sd_ble_gap_lesc_oob_data_get, requires local LE Secure Connection
P256 Public Keys in {X,Y} format, but was being supplied with
the local secret key. This caused the generated OOB data to
fail to correspond to the Public Keys, which caused a mismatch
during the OOB pairing phase of the OOB confirmation value by
a remote peer when attempting to verify the OOB data against
the Public Keys, ultimately causing the OOB pairing request to
fail with a Confirm Value Failed (0x04) error.
the own_oob and peer_oob flags were not being set to 1 even though an OOB pairing request was in progress, which therefore prevented OOB data from being passed down to the softdevice during a OOB pairing operation, thus causing the OOB pairing process to fail.
|
Target was added to examples listed below:
And release candidate list is:
|
|
Correct, I was not looking at the proper file. |
|
On the plus side, I'm pleased CI caught a merge issue. |
0xc0170
force-pushed
the
release-candidate
branch
from
5776441
to
3f5c4de
Compare
|
Fixed wrong target addition ("FVP_MPS2_M3" in system info now) |
|
I triggered CI on this PR on behalf of @0xc0170 |
Test run: FAILEDSummary: 1 of 12 test jobs failed Failed test jobs:
|
|
failure in K66 tests , re-reunning CI to make sure it is not a sporadic issue |
Test run: FAILEDSummary: 1 of 12 test jobs failed Failed test jobs:
|
|
Restarted failed greentea tests |
0xc0170
approved these changes
Jan 28, 2019
|
Waiting for last approvals |
added 3 commits
January 30, 2019 17:37
FlashIAP driver: Add retries to erase and program operations.
mbed_die: Use wait_us not wait_ms
Halt to enforce reboot limit once only
|
Cherry picked (hopefully) remaining PRs. Will start CI once Travis CI completes. |
This was referenced Jan 30, 2019
|
CI started |
|
We have a problem of building armc6/iar8 for release candidates. @ARMmbed/mbed-os-test |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
|
Restarted CI |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.