Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cellular: Fix sigio to be released in ATHandler destructor #9728

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Cellular: Fix sigio to be released in ATHandler destructor #9728

merged 1 commit into from
Feb 15, 2019

Conversation

AriParkkila
Copy link

Description

ATHandler destructor must release sigio callbacks from filehandle.

Fixes issue #9723.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mirelachirica

Release Notes

@ciarmcom ciarmcom requested review from mirelachirica and a team February 15, 2019 10:00
@ciarmcom
Copy link
Member

@AriParkkila, thank you for your changes.
@mirelachirica @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team February 15, 2019 10:00
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 15, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 15, 2019

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 15, 2019

Please review the unit tests failures

@AriParkkila
Copy link
Author

@0xc0170 fixed unittests, should be fine for merge.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 15, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Feb 15, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit fdd2a94 into ARMmbed:master Feb 15, 2019
@cmonr cmonr removed the needs: CI label Feb 15, 2019
@AriParkkila AriParkkila mentioned this pull request Mar 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjbracey kjbracey kjbracey approved these changes

@mirelachirica mirelachirica mirelachirica approved these changes

@jarvte jarvte jarvte approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AriParkkila @ciarmcom @0xc0170 @mbed-ci @kjbracey @mirelachirica @jarvte @cmonr