Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SPM returning the wrong value #9754

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Fix SPM returning the wrong value #9754

merged 1 commit into from
Feb 19, 2019

Conversation

netanelgonen
Copy link
Contributor

Description

Change the return value in case of an illegal operation handle.
change from PSA_ERROR_INVALID_ARGUMENT to PSA_ERROR_BAD_STATE according to PSA specifications.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@itayzafrir

Release Notes

@ciarmcom ciarmcom requested review from itayzafrir and a team February 19, 2019 12:00
@ciarmcom
Copy link
Member

@netanelgonen, thank you for your changes.
@itayzafrir @ARMmbed/mbed-os-maintainers please review.

itayzafrir
itayzafrir approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@itayzafrir itayzafrir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xc0170
0xc0170 approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1:1 with the docs in crypto.h

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 19, 2019

CI started

@cmonr cmonr merged commit 9f6ee7d into ARMmbed:master Feb 19, 2019
@netanelgonen netanelgonen mentioned this pull request Feb 25, 2019
Merged
netanelgonen pushed a commit to netanelgonen/mbed-os that referenced this pull request Feb 25, 2019
reopening ARMmbed#9754 after the changes where overrun
b5b0e98 
changing the SPM error codes from invalid argument to bad state aligned to PSA spec
rajkan01 pushed a commit to rajkan01/mbed-os that referenced this pull request Mar 7, 2019
@rajkan01
reopening ARMmbed#9754 after the changes where overrun
f863fab 
changing the SPM error codes from invalid argument to bad state aligned to PSA spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@itayzafrir itayzafrir itayzafrir approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@netanelgonen @ciarmcom @0xc0170 @itayzafrir @cmonr