Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPM returning the wrong value #9754

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
5 participants
@netanelgonen
Copy link
Contributor

commented Feb 19, 2019

Description

Change the return value in case of an illegal operation handle.
change from PSA_ERROR_INVALID_ARGUMENT to PSA_ERROR_BAD_STATE according to PSA specifications.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@itayzafrir

Release Notes

Netanel Gonen

@ciarmcom ciarmcom requested review from itayzafrir and ARMmbed/mbed-os-maintainers Feb 19, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

@netanelgonen, thank you for your changes.
@itayzafrir @ARMmbed/mbed-os-maintainers please review.

@itayzafrir
Copy link
Contributor

left a comment

LGTM

@0xc0170
Copy link
Member

left a comment

1:1 with the docs in crypto.h

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

CI started

@cmonr cmonr merged commit 9f6ee7d into ARMmbed:master Feb 19, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9202 cycles (+48 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 19, 2019

@netanelgonen netanelgonen referenced this pull request Feb 25, 2019

Merged

Fix SPM error codes #9829

netanelgonen pushed a commit to netanelgonen/mbed-os that referenced this pull request Feb 25, 2019

Netanel Gonen
reopening ARMmbed#9754 after the changes where overrun
changing the SPM error codes from invalid argument to bad state aligned to PSA spec

netanelgonen pushed a commit to kfnta/mbed-os that referenced this pull request Feb 25, 2019

Netanel Gonen
reopening ARMmbed#9754 after the changes where overrun
changing the SPM error codes from invalid argument to bad state aligned to PSA spec

rajkan01 added a commit to rajkan01/mbed-os that referenced this pull request Mar 7, 2019

reopening ARMmbed#9754 after the changes where overrun
changing the SPM error codes from invalid argument to bad state aligned to PSA spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.