Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPM error codes #9829

Merged

Conversation

Projects
None yet
7 participants
@netanelgonen
Copy link
Contributor

commented Feb 25, 2019

Description

reopening #9754 after the changes where overrun
changing the SPM error codes from invalid argument to bad state aligned to PSA spec

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@itayzafrir

Release Notes

@NirSonnenschein NirSonnenschein requested review from avolinski, itayzafrir and ARMmbed/mbed-os-maintainers Feb 25, 2019

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

Note: these changes were already merged to master and then overwritten by a later PR. This should just add them back in.

@0xc0170
Copy link
Member

left a comment

revert 100644 → 100755 file permission change

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

thanks @0xc0170 , fixed

@0xc0170

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

@netanelgonen Can you add this to the commit msg:

reopening #9754 after the changes where overrun
changing the SPM error codes from invalid argument to bad state aligned to PSA spec

I knew I saw it previously (this fix). Once added, we will start CI

@itayzafrir
Copy link
Contributor

left a comment

LGTM

Netanel Gonen
reopening #9754 after the changes where overrun
changing the SPM error codes from invalid argument to bad state aligned to PSA spec

@netanelgonen netanelgonen force-pushed the netanelgonen:re-issuing-the-fix-for-SPM-error-codes branch to b5b0e98 Feb 25, 2019

@NirSonnenschein

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

fixed , stating CI

@mbed-ci

This comment has been minimized.

Copy link

commented Feb 25, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 25, 2019

@cmonr cmonr merged commit afeab0f into ARMmbed:master Feb 25, 2019

27 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10042 cycles (-465 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.