Fix SPM error codes #9829
Merged
Fix SPM error codes #9829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NirSonnenschein
approved these changes
Feb 25, 2019
|
Note: these changes were already merged to master and then overwritten by a later PR. This should just add them back in. |
0xc0170
requested changes
Feb 25, 2019
|
thanks @0xc0170 , fixed |
0xc0170
approved these changes
Feb 25, 2019
|
@netanelgonen Can you add this to the commit msg:
I knew I saw it previously (this fix). Once added, we will start CI |
0xc0170
added
needs: work
risk: G
release-version: 5.12.0-rc1
and removed
needs: review
labels
changing the SPM error codes from invalid argument to bad state aligned to PSA spec
netanelgonen
force-pushed
the
re-issuing-the-fix-for-SPM-error-codes
branch
from
8ca4f0f
to
b5b0e98
Compare
|
fixed , stating CI |
alekshex
approved these changes
Feb 25, 2019
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reopening #9754 after the changes where overrun
changing the SPM error codes from invalid argument to bad state aligned to PSA spec
Pull request type
Reviewers
@itayzafrir
Release Notes