Feature watchdog #9840

rajkan01 · 2019-02-25T14:42:13Z

Description

Based on Review comments from PR #9243, rebased feature-watchdog against master branch

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

adbridge · 2019-02-25T15:15:55Z

ci started

cmonr · 2019-02-25T15:27:21Z

Fyi, changed the base branch to ARMmbed/master instead of the feature branch.

If the rebased branch attempts to target the curent feature branch, GitHub attempts to create a merge commit between the two, which isn't what we want to put through CI.

Instead, targeting ARMmbed/master creates a merge commit that's more appropriate for what we're trying to do with this PR.

Once this passes CI and is OK'd by reviewers, it will be closed and maintainers will force-push the new feature branch.

Some more details can be found here: #8989 (comment)
Official docs coming soon (since we're finally needing to rebase feature branches more often 😁 )

cmonr · 2019-02-25T15:32:44Z

@rajkan01 Was this rebased against your local master branch?

The TravisCI test list appears to be missing some improvements, and your local master branch appears a bit out of date:

This branch is 1219 commits behind ARMmbed:master.

rajkan01 · 2019-02-25T15:39:49Z

Done git rebase origin/master command rebased against master….

cmonr · 2019-02-25T16:40:34Z

CI restarted.

cmonr · 2019-02-25T16:46:06Z

@rajkan01 Let us know when this is ready to be tested against CI

rajkan01 · 2019-02-25T16:47:46Z

Currently I have rebased against origin/master and pushed ,can try with CI

cmonr · 2019-02-25T22:15:34Z

@rajkan01 It looks like one of the Travis CI jobs failed. Please fix the typo, then we can get Jenkins CI started.

cmonr · 2019-02-25T22:45:37Z

CI started

mbed-ci · 2019-02-25T23:36:38Z

Test run: FAILED

Summary: 6 of 8 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
jenkins-ci/mbed-os-ci_mbed2-build-ARM
jenkins-ci/mbed-os-ci_mbed2-build-IAR
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-ARM

cmonr · 2019-02-25T23:46:11Z

@rajkan01 Please take a look at the build failures.

It appears that there are reset tests that have some issues.

fkjagodzinski · 2019-02-26T10:45:14Z

@rajkan01 I think your branch is missing a few commits that the original feature-watchdog had. There are reset_reason fixes from @scartmell-arm among them.

Make minor grammar edits.

* capitalize driver class name, * reword test docs for the driver & HAL, * capitalize Mbed name, * reword the comments explaining the SERIAL_FLUSH_TIME_MS macro.

Not sure if the formatting's still alright on these.

Hope this is alright.

This reverts commit 3ce1d4940cb7fd9d74ca2be75ed08b76854ff534.

…G for H743ZI board

rajkan01 · 2019-03-07T09:59:24Z

there's a conflict, please rebase

I resolved the conflicts, Please start the CI

0xc0170 · 2019-03-07T11:16:17Z

CI restarted

mbed-ci · 2019-03-07T13:32:54Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 12
Build artifacts

0xc0170 · 2019-03-07T13:38:37Z

@rajkan01 @donatieng This rebase is ready to be pushed t o the feature branch!

cmonr · 2019-03-07T17:55:20Z

@rajkan01 @donatieng Feature branch rebase complete.

ARMmbed/feature-watchdog is now the same as rajkan01:feature-watchdog

jeromecoutant · 2019-03-14T09:21:59Z

ARMmbed/feature-watchdog is now the same as rajkan01:feature-watchdog

Then, when is the target to merge feature branch to master ?

rajkan01 · 2019-03-14T10:18:44Z

ARMmbed/feature-watchdog is now the same as rajkan01:feature-watchdog

Then, when is the target to merge feature branch to master ?

once feature-watchdog-v1-rb branch changes get merged..

cmonr changed the base branch from feature-watchdog to master February 25, 2019 15:08

cmonr added do not merge needs: CI labels Feb 25, 2019

cmonr requested review from jeromecoutant, a user, stevew817, donatieng, fkjagodzinski and ccli8 February 25, 2019 15:30

rajkan01 force-pushed the feature-watchdog branch from 1c1cbd2 to 22dc03c Compare February 25, 2019 16:43

cmonr added needs: work and removed needs: CI labels Feb 25, 2019

cmonr added needs: CI and removed needs: work labels Feb 25, 2019

cmonr added needs: work and removed needs: CI labels Feb 25, 2019

rajkan01 changed the base branch from master to feature-watchdog February 26, 2019 11:12

rajkan01 force-pushed the feature-watchdog branch from d77b06d to 03b0ec5 Compare February 26, 2019 11:22

Ganesh Ramachandran and others added 19 commits March 7, 2019 09:30

Added reset_reason feature for TMPM3HQ

ecac5fd

Edit ResetReason_tests.h

30ea3d5

Make minor grammar edits.

fix: Remove excess comma from device_has key in targets.json

9f3c61b

fix(hal-watchdog): Remove 'RESET_REASON' flags from unsupported devices

069584a

fix(hal-watchdog): Add 'RESET_REASON' flags to supported devices

44904ee

fix(hal-watchdog): Guard TMPM 'ResetReason' code behind feature flag

f5b4644

Docs: Watchdog: Update code comments

79d5888

* capitalize driver class name, * reword test docs for the driver & HAL, * capitalize Mbed name, * reword the comments explaining the SERIAL_FLUSH_TIME_MS macro.

small grammatical changes

10515d6

Not sure if the formatting's still alright on these.

Capitalizing Watchdog

1113ea0

capitalizing class name

a1d4adb

Hope this is alright.

update:Remove DEVICE_WATCHDOG and added RESET_RESON in stm32 family

9a90636

doxy spell check fix for watchdog

7670a2c

fix for build failure issues

78cee3c

Revert "fix for build failure issues"

2fdd400

This reverts commit 3ce1d4940cb7fd9d74ca2be75ed08b76854ff534.

Removed RESET_REASON for NRF52832,NRF52840 family and Removed WATCHDO…

3862e15

…G for H743ZI board

fix for Jenkin build issue

d418d11

Trailing space issue fix

108daf3

Added the SPDX identifier

a05cd27

Removed RESET_REASON for NRF51_DK board

7e5833e

rajkan01 force-pushed the feature-watchdog branch from 6923fd0 to 7e5833e Compare March 7, 2019 09:31

cmonr closed this Mar 7, 2019

cmonr removed do not merge needs: CI labels Mar 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature watchdog #9840

Feature watchdog #9840

rajkan01 commented Feb 25, 2019 •

edited by cmonr

Loading

adbridge commented Feb 25, 2019

cmonr commented Feb 25, 2019

cmonr commented Feb 25, 2019

rajkan01 commented Feb 25, 2019 via email •

edited

Loading

cmonr commented Feb 25, 2019

cmonr commented Feb 25, 2019

rajkan01 commented Feb 25, 2019 via email •

edited

Loading

cmonr commented Feb 25, 2019

cmonr commented Feb 25, 2019

mbed-ci commented Feb 25, 2019

cmonr commented Feb 25, 2019

fkjagodzinski commented Feb 26, 2019

rajkan01 commented Mar 7, 2019

0xc0170 commented Mar 7, 2019

mbed-ci commented Mar 7, 2019

0xc0170 commented Mar 7, 2019

cmonr commented Mar 7, 2019 •

edited

Loading

jeromecoutant commented Mar 14, 2019

rajkan01 commented Mar 14, 2019

Feature watchdog #9840

Feature watchdog #9840

Conversation

rajkan01 commented Feb 25, 2019 • edited by cmonr Loading

Description

Pull request type

Reviewers

Release Notes

adbridge commented Feb 25, 2019

cmonr commented Feb 25, 2019

cmonr commented Feb 25, 2019

rajkan01 commented Feb 25, 2019 via email • edited Loading

cmonr commented Feb 25, 2019

cmonr commented Feb 25, 2019

rajkan01 commented Feb 25, 2019 via email • edited Loading

cmonr commented Feb 25, 2019

cmonr commented Feb 25, 2019

mbed-ci commented Feb 25, 2019

Test run: FAILED

cmonr commented Feb 25, 2019

fkjagodzinski commented Feb 26, 2019

rajkan01 commented Mar 7, 2019

0xc0170 commented Mar 7, 2019

mbed-ci commented Mar 7, 2019

Test run: SUCCESS

0xc0170 commented Mar 7, 2019

cmonr commented Mar 7, 2019 • edited Loading

jeromecoutant commented Mar 14, 2019

rajkan01 commented Mar 14, 2019

rajkan01 commented Feb 25, 2019 •

edited by cmonr

Loading

rajkan01 commented Feb 25, 2019 via email •

edited

Loading

rajkan01 commented Feb 25, 2019 via email •

edited

Loading

cmonr commented Mar 7, 2019 •

edited

Loading