Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for .obj files in memap #9851

Merged
merged 1 commit into from
Feb 27, 2019
Merged

feat: add support for .obj files in memap #9851

merged 1 commit into from
Feb 27, 2019

Conversation

vidavidorra
Copy link
Contributor

Description

Add support for .obj files in memap tool. CMake/gcc-arm-none-eabi builds generate .obj files so this allows those builds to use the memap tool as well.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@theotherjimmy

Release Notes

  • A brief description of changes introduced.
    Add support for .obj files in memap tool.
  • An analysis of effects: components affected, potential consequences for users and reasons for the addition or change.
    Affects tools component, behaviour doesn't change for existing users. This adds support for using the memap tool for CMake/gcc-arm-none-eabi builds (and maybe others too).
  • Migration guidance: actions for updating the current code. Please include code snippets to illustrate before and after the addition or change.
    N/A

@ciarmcom ciarmcom requested review from theotherjimmy and a team February 26, 2019 14:00
@ciarmcom
Copy link
Member

@vidavidorra, thank you for your changes.
@theotherjimmy @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you added support for ARM and IAR to produce .obj files as well

@vidavidorra
Copy link
Contributor Author

I like that you added support for ARM and IAR to produce .obj files as well

@theotherjimmy Haha, I take it those don't create .obj files 😄
I only use GCC_ARM and with that I ran into this issue. If ARM and IAR don't produce .obj, I can remove those parts. After all, no need to have that option in there if they don't produce such file(s).

@theotherjimmy
Copy link
Contributor

@vidavidorra This allows us to add a cmake_arm or cmake_iar without any need to update memap too, so I say we keep it.

@cmonr
Copy link
Contributor

cmonr commented Feb 26, 2019

CI started

@cmonr cmonr added the risk: G label Feb 26, 2019
@mbed-ci
Copy link

mbed-ci commented Feb 27, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants