Correct thread status callback functionality #9971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KariHaapalehto, thank you for your changes. |
VeijoPesonen
approved these changes
Mar 7, 2019
0xc0170
previously requested changes
Mar 7, 2019
SeppoTakalo
approved these changes
Mar 7, 2019
|
At the start-up, there was 2 NSAPI_STATUS_CONNECTING callbacks, so extra one removed from ThreadInterface.cpp. |
At the start-up, there was 2 NSAPI_STATUS_CONNECTING callbacks, so extra one removed from ThreadInterface.cpp. At the network lost case, there was NSAPI_STATUS_DISCONNECTED and NSAPI_STATUS_LOCAL_UP callbacks. NSAPI_STATUS_DISCONNECTED has been removed, since the NSAPI_STATUS_LOCAL_UP is enought.
KariHaapalehto
force-pushed
the
status_callback
branch
from
e6390e3
to
d944836
Compare
|
@KariHaapalehto what is the status of this PR ? |
cmonr
approved these changes
Mar 27, 2019
|
@adbridge This one was waiting on us. Commit message was updated a while ago. |
|
CI started |
Test run: FAILEDSummary: 1 of 13 test jobs failed Failed test jobs:
|
|
restarted exporter |
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 28, 2019
Correct thread status callback functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Status callback correct.
Tested locally with k64f using thread mesh network.
Pull request type
Reviewers
Release Notes