-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added function generate_twospirals from matlab #17
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 36 56 +20
=========================================
+ Hits 36 56 +20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tem como adicionar testes? Ainda não estamos fazendo testes elaborados, mas seria legal ter no mínimo se a função funciona.
Added 1 test for generate_twospirals function.
Forgot to create matlab testset in last commit, so did it now.
Adicionei os teste que você pediu, aconteceu o conflito pois foram feitos outros testes desde que eu clonei o master. |
Eu dei uma atualizada no projeto. Além disso, eu vou fazer um comentário no código. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faltando também o README
…tion' into feature/generate_twospirals_function
Adicionei a função generate_twospirals do matlab.
![Imagem_Two_Spirals](https://user-images.githubusercontent.com/51464923/92290664-46286880-eeeb-11ea-9a33-1c52e9283310.png)