Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added function generate_twospirals from matlab #17

Merged
merged 8 commits into from
Sep 10, 2020
Merged

Added function generate_twospirals from matlab #17

merged 8 commits into from
Sep 10, 2020

Conversation

Sergiorezende22
Copy link
Member

@Sergiorezende22 Sergiorezende22 commented Sep 4, 2020 •
edited

Adicionei a função generate_twospirals do matlab.
Imagem_Two_Spirals

@Sergiorezende22 Sergiorezende22 linked an issue Sep 4, 2020 that may be closed by this pull request
Implementação de seis geradores do MatLab #3
Open
6 tasks
@codecov
Copy link

codecov bot commented Sep 4, 2020 •
edited

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines           36        56   +20     
=========================================
+ Hits            36        56   +20
Impacted Files Coverage Δ
src/SyntheticDatasets.jl 100.00% <ø> (ø)
src/matlab.jl 100.00% <100.00%> (ø)
src/sklearn.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf7441...5a04df2. Read the comment docs.

filipebraida
filipebraida requested changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@filipebraida filipebraida left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tem como adicionar testes? Ainda não estamos fazendo testes elaborados, mas seria legal ter no mínimo se a função funciona.

@Sergiorezende22
Adding tests
11aab71 
Added 1 test for generate_twospirals function.
@Sergiorezende22
Adding Matlab testset
251561b 
Forgot to create matlab testset in last commit, so did it now.
@Sergiorezende22
Copy link
Member Author

Sergiorezende22 commented Sep 8, 2020 •
edited

Adicionei os teste que você pediu, aconteceu o conflito pois foram feitos outros testes desde que eu clonei o master.

@filipebraida
Copy link
Contributor

Eu dei uma atualizada no projeto.
Está falando o README file.

Além disso, eu vou fazer um comentário no código.

filipebraida
filipebraida requested changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@filipebraida filipebraida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faltando também o README

src/matlab.jl Outdated Show resolved Hide resolved
@filipebraida filipebraida merged commit e09eaa2 into master Sep 10, 2020
@filipebraida filipebraida deleted the feature/generate_twospirals_function branch September 10, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipebraida filipebraida filipebraida approved these changes

@Conradox Conradox Awaiting requested review from Conradox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementação de seis geradores do MatLab
2 participants
@Sergiorezende22 @filipebraida