Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Lora activation string is not applied to the prompt #15184

Closed
2 of 6 tasks
syntaxterror9 opened this issue Mar 8, 2024 · 1 comment · Fixed by #15199
Closed
2 of 6 tasks

[Bug] Lora activation string is not applied to the prompt #15184

syntaxterror9 opened this issue Mar 8, 2024 · 1 comment · Fixed by #15199
Labels
bug Report of a confirmed bug bug-report Report of a bug, yet to be confirmed

Comments

@syntaxterror9
Copy link

syntaxterror9 commented Mar 8, 2024

Checklist

  • The issue exists after disabling all extensions
  • The issue exists on a clean installation of webui
  • The issue is caused by an extension, but I believe it is caused by a bug in the webui
  • The issue exists in the current version of the webui
  • The issue has not been reported before recently
  • The issue has been reported before but has not been fixed yet

What happened?

After upgrading to v1.8.0 when I add a Lora activation string in the Lora details window that string is not applied to the prompt when I click the Lora in the Lora selection tab. The Lora string ( <some-kind-of-lora:1.0> ) is added but no activation string is added after that.

This happens only with newly added Loras (and also on old Loras where I didn't edited the activation string). If I had already defined activation strings on older Loras I can edit them and the recent changes are reflected on the prompt when I select the Lora.

windows11
version: [v1.8.0] •  python: 3.10.6  •  torch: 2.0.1+cu118  •  xformers: N/A  •  gradio: 3.41.2

Steps to reproduce the problem

  1. go to lora selection tab
  2. click edit details on a Lora (with no activation string defined)
  3. add an activation string
  4. click on the lora and check the string added to the prompt

What should have happened?

the new activation string should appear after the lora reference: "<a-lora:1.0> some-activation-string"

What browsers do you use to access the UI ?

Mozilla Firefox, Microsoft Edge

Sysinfo

Console logs

-

Additional information

No response

@syntaxterror9 syntaxterror9 added the bug-report Report of a bug, yet to be confirmed label Mar 8, 2024
@w-e-w
Copy link
Collaborator

w-e-w commented Mar 9, 2024

thanks for the report
confirm bug

@w-e-w w-e-w added the bug Report of a confirmed bug label Mar 9, 2024
@w-e-w w-e-w linked a pull request Mar 9, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of a confirmed bug bug-report Report of a bug, yet to be confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants