Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Highresfix denoising strength behaviour has changed since a day or two ago and is causing blurryness. #3630

Closed
1 task done
Reinbowsaur opened this issue Oct 25, 2022 · 14 comments
Labels
asking-for-help-with-local-system-issues This issue is asking for help related to local system; please offer assistance

Comments

@Reinbowsaur
Copy link

Reinbowsaur commented Oct 25, 2022

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What happened?

Images below 0.7 Denoinsing strength generate blurry in high res fix.. especially at high resolutions. Before you could do 0.4 to apply slight noise for it to re-step through, but instead it now it seems to resolve noise worse and worse the lower you set it, and is also applying the incorrect noise to resolve at these levels.

It wasn't like this a the other day, I'm pretty sure image2image broke the other day too and after that was fixed, I noticed this issue. Somehow related?

Steps to reproduce the problem

  1. Enable high res fix on something close to like 1400x1000, euler a 28steps, any prompt.
  2. Try any denoising strengths below 0.7
  3. Observe and compare denoising strengths results ranging from 0-0.7 it just makes the sharpness and quality worse and worse the lower you go.

What should have happened?

A nice sharp image. This never used to happen, instead less things would change, now it's as if it doesn't resolve the the noise at all.

Commit where the problem happens

No clue.

What platforms do you use to access UI ?

Other/Cloud

What browsers do you use to access the UI ?

Google Chrome

Command Line Arguments

--share --gradio-debug --no-half-vae --xformers

Additional information, context and logs

Using novel AI model, have never changed my setup apart from keep up to date with the repo.

@Reinbowsaur Reinbowsaur added the bug-report Report of a bug, yet to be confirmed label Oct 25, 2022
@Reinbowsaur Reinbowsaur changed the title [Bug]: Denoising strength behaviour has changed since a day or two ago and is causing blurryness. [Bug]: Highresfix denoising strength behaviour has changed since a day or two ago and is causing blurryness. Oct 25, 2022
@ClashSAN
Copy link
Collaborator

was ca5a9e7 the commit the broke the denoise?
I'll test it later locally to see if I get worse results.

@Enferlain
Copy link

Not sure about highres, but I've been using img2img a lot and under the same settings (near 512, same prompts, 0.45 strength, 28 steps 15cfg) I'm getting way worse quality results. Like blurry lines, and faces look worse, hands used to be sometimes good, now they're messed up 90% of the time, you get the idea.

Even 0.3-0.35 was fine for good outputs for me, but it just looks so bad for some reason. I haven't been keeping up with changelogs so I don't know what happened, but it wasn't like this when I used it last time about 5 days ago.

Oh and for me text2img seems worse in quality as well.

image

@Reinbowsaur
Copy link
Author

Reinbowsaur commented Oct 26, 2022

ダウンロード.jpg…
Example when of denoise levels with highresfix. It shouldn't be applying noise like this, if at all at level 0.
1girl, smile Negative prompt: lowres, bad anatomy, bad hands, text, error, missing fingers, extra digit, fewer digits, cropped, worst quality, low quality, normal quality, jpeg artifacts, signature, watermark, username, (((deformed))), [blurry], bad anatomy, disfigured, poorly drawn face, mutation, mutated, (extra_limb), (ugly), (poorly drawn hands), messy drawing, broken legs Steps: 28, Sampler: Euler a, CFG scale: 11, Seed: 1624647752, Size: 1024x1024, Model hash: 925997e9, Denoising strength: 0.7, Clip skip: 2, First pass size: 0x0

@ClashSAN
Copy link
Collaborator

old be1596c

--medvram --xformers

new 99d728b

--medvram --xformers

Control Images

default model, seed 5,6,7 euler a, 20 steps, prompt: "frog" cfg 7
01791-7-frog
01790-6-frog
01789-5-frog

Img2img

denoise 0.7, seed 1, prompt: "frog" euler a, 20 steps

old

00309-1-frog
00308-1-frog
00307-1-frog

new

00013-1-frog
00011-1-frog
00012-1-frog

So its not anything to do with colab or the novel ai model, img2img differences are in the normal 1.4 model as well.

@ClashSAN ClashSAN added bug Report of a confirmed bug help wanted and removed bug-report Report of a bug, yet to be confirmed labels Oct 26, 2022
@vanhoe0
Copy link

vanhoe0 commented Nov 1, 2022

Same issue using txt2img. It is very noticeable for denoising from 0.4 and below.
Steps: 20, Sampler: Euler, CFG scale: 7, Seed: 1336575059, Size: 1024x1024, Model hash: 81761151, Model: v1-5, Denoising strength: 0.0, First pass size: 0x0
xy_grid-0005-1336575059-masterpiece, highly detailed, cinematic, full body, (dynamic pose), armored suit, hands gripped, cute face, perfect face, biomec

@TORN-DIR
Copy link

TORN-DIR commented Nov 5, 2022

As a comparison, I want to just add that i2i denoise seems to work fine.
I am unsure if that i2i is what the highres fix result SHOULD look like, but if so, the result is desireable.
t2i vs i2i denoise comparison

@williamkmlau
Copy link

Just wondering if this would be related to the setting/feature where less steps are taken the lower the denoising level

@marcsyp
Copy link

marcsyp commented Mar 12, 2023

Has there been any further response to this? I am running into these issues as well using t2i -- finding that anything under 0.4 with latent upscaling results in unusable blurry images, which kind of eliminates the possibility of using latent upscaling. I've moved to Lanczos upscaling but it doesn't have the ability to add detail the way latent can...

@Enferlain
Copy link

Thought that was normal, but maybe not? Using nearest for upscale and being below 0.5 denoise definitely results in blurry or pixelated images.

@ToxicObsidian
Copy link

Hope my comments here can help you.

@catboxanon catboxanon added asking-for-help-with-local-system-issues This issue is asking for help related to local system; please offer assistance and removed bug Report of a confirmed bug labels Aug 5, 2023
@ywj5782
Copy link

ywj5782 commented Dec 24, 2023

lora:aurora-style-richy-v1:1, aurorastyle, official art, unity 8k wallpaper, ultra detailed, beautiful and aesthetic, masterpiece, best quality, (zentangle, mandala, tangle, entangle), (fractal art:1.3), 1girl, extremely detailed, dynamic angle, cowboyshot, the most beautiful form of chaos, elegant, a brutalist designed, vivid colours, romanticism, by james jean, roby dwi antono, ross tran, francis bacon, michal mraz, adrian ghenie, petra cortright, gerhard richter, takato yamamoto, ashley wood, atmospheric, ecstasy of musical notes, streaming musical notes visible,
Negative prompt: (worst quality:2,low quality:2), (interlocked fingers,badly drawn hands and fingers, anatomically incorrect hands),
Steps: 30, Sampler: DPM++ 2M Karras, CFG scale: 9, Seed: 1072721686, Size: 384x704, Model hash: f1270c1f02, Model: zavychromaxl_v30,

p1:Denoising strength: 0.6

p2:Denoising strength: 0.4

Hypertile VAE: True, Hires resize: 768x1368, Hires upscaler: Latent, Lora hashes: "aurora-style-richy-v1: d331bdff9591", Version: v1.7.0
00018-1072721686
00019-1072721686

@aleksusklim
Copy link

p2:Denoising strength: 0.4

Hires upscaler: Latent

Latent upscaler demands denoisinig strength to be larger than 0.5

@Reinbowsaur
Copy link
Author

p2:Denoising strength: 0.4

Hires upscaler: Latent

Latent upscaler demands denoisinig strength to be larger than 0.5

This is really old. But I'll explain. At the time of posting high-res fix was quite different, and until recently before that post, you used to be able to use Denise strength values of below 0.5 without a problem, or weird artifacts, some behaviour or code was changed, fairly certain of it.

@Reinbowsaur
Copy link
Author

Will close this. If anyone happens to have info related to the code behind this issue and how it was in the past feel free to share and reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asking-for-help-with-local-system-issues This issue is asking for help related to local system; please offer assistance
Projects
None yet
Development

No branches or pull requests