Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Disable PNGInfo #5806

Closed
1 task done
WASasquatch opened this issue Dec 17, 2022 · 6 comments
Closed
1 task done

[Feature Request]: Disable PNGInfo #5806

WASasquatch opened this issue Dec 17, 2022 · 6 comments

Comments

@WASasquatch
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

I personally find the PNGInfo a gimmick, and abusing PNG Tags concept, which is for ownership information and camera information for post processing.

Is this able to be disabled? I shouldn't have to sanitize my creations before I share them, and I myself have warned a few people that they were selling assets with full reproducibility and ability to easily derive from, no payment necessary, cause their preview images load fine into webui. Pretty sure a lot of modern image editors respect PNG Info and roll it over to new saves, too even if you edit it (like post processing).

Proposed workflow

  1. Go to Settings
  2. Disable PNGInfo
  3. Incorporate program level logic for send to image if it relies on it.

Additional information

I don't feel this is safe default behavior for a end-point usage utility. That's like if TIFF had save layers by default, or meta data stating every filter/operation used in a DCC.

@BetaDoggo
Copy link

Under the "Saving images/grids" section in settings there is a setting called "Do not add watermark to images". I think that does what you're asking here.

@parazite7
Copy link

This has always been a feature.
image

@aliencaocao
Copy link
Contributor

@ClashSAN consider closing this since this feature is already there

@WASasquatch
Copy link
Author

This has always been a feature. image

That's a pretty interesting title since it's PNG Info and PNG Tags system. I can see why I overlooked it. Like, what is "chunks" lol? This could use better naming, relating to what is actually used in the UI/Code.

@aliencaocao
Copy link
Contributor

'Chunks' refer to additional data that is being saved with the file. The PNG file structure is made up of different chunks of data, and some of them are for image, others are for metadata like comments

@WASasquatch
Copy link
Author

WASasquatch commented Dec 17, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants