Preserve Python 3.9 compatibility #10578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I know Colab has been upgraded to 3.10 by default. |
|
Oh, I was unaware of the update. Regardless, Paperspace Gradient is still on 3.9, which is where I was testing and what a lot of people now use after Colab restricted WebUI usage for the free tier. |
AUTOMATIC1111
approved these changes
May 20, 2023
|
wish out linter told us about that |
|
@AUTOMATIC1111 The alternative fix is to add |
|
Merging the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this pull request is trying to achieve.
The dev branch currently does not launch due to a TypeError in Python 3.9 environments (e.g. Colab Pro, Paperspace Gradient). This is because of newer Optional type syntax usage in
shared.pyadded by #10458. This PR changes three lines to usetyping.Optionalinstead to preserve backwards compatibility.Additional notes and description of your changes
It's a minor syntax change and I've tested launch and restarts to be working but please ensure everything is correct as I'm not really a programmer. Thank you.
Environment this was tested in