chore: use gfpgan stable codebase

[soulteary]

Description

The WebUI project, currently using the GFPGAN code version, comes from an unstable version, taken from a temporary commit after the release of 1.3.5.

For consistency, refer to the requirements file, it is recommended to use version 1.3.8 of the stable version.

Checklist:

• I have read contributing wiki page
• I have performed a self-review of my own code
• My code follows the style guidelines
• My code passes tests

[soulteary]

it seems i can not re trigger the https://github.com/AUTOMATIC1111/stable-diffusion-webui/actions/runs/5736676815/job/15546757906?pr=12252 , since i change the target branch to dev. @AUTOMATIC1111

[w-e-w]

the workflow it's only triggered on opened synchronize and reopened
unless you close and reopen or push new changes to your PR it won't rerun the the workflow

that workflow is only meant as a warning triggered when someone tries to commit to the master branch
you have already changed your targets to dev so don't worry about it

if you really want the warning gone, close then re-open the this pr

[AUTOMATIC1111]

is something improved

[w-e-w]

if this gets merged I would suggest using the hash as opposed to the tag

[soulteary]

i've try to close and reopen this PR, but the warnning CI job not disappear. @w-e-w lol

[soulteary]

i've try to close and reopen this PR, but the warnning CI job not disappear. @w-e-w lol

[w-e-w]

ah I see
since the job was already run it's not going to be rerunned and ceared so it's still error is there
I'll see what I can do about this in the future

but it's really just something that to tell new developers that you should base your code off of dev branch instead of master
as depending on where we are in the development cycle, we have seen people submit PR that's trying to fix stuff in master that's already been fixed in dev

[soulteary]

emmmm, Is there anything else I need to do on this?

[AUTOMATIC1111]

You need to explain what the reason is for updating to a newer version of GFPGAN.

[AUTOMATIC1111]

Actually I think 1.3.8 is what we use - it's in requirements_versions.txt. Maybe we don't need that installation code in the launcher at all.

[soulteary]

Ok, I initially thought this was designed to use a fixed version of the software, as a feature supplement

But after reading the commit record and requirement file, it seems that this is the place that is left out.

Currently the requirement file contains the correct 1.3.8 version, but this is ignored in launch?

Perhaps the same version should be installed when installing in the bottom of the bag here?

[AUTOMATIC1111]

no, no, it's not ignored, if you check your installed pip version in webui's venv you would probably have 1.3.8 - I do. it is installed in launch_utils.py, line 399.

[AUTOMATIC1111]

I checked on a new installation that GFPGAN_PACKAGE is not needed and pushed a change that removes that part of launch_utils.