Use absolute path for normalized filepath

[catboxanon]

Description

Small oversight I made as part of #14934. resolve was changing paths to use the symlink, causing there to be multiple representations of a path (it should use a single representation, that representation being the path as it appears to the user).

Fixes these issues (upscalers being listed twice due to multiple path representations, and symlinks/junctions breaking due to using the linked path and thus falling "outside" the Gradio directory):
lllyasviel/stable-diffusion-webui-forge#313
lllyasviel/stable-diffusion-webui-forge#282
#14942 (comment)

Checklist:

• I have read contributing wiki page
• I have performed a self-review of my own code
• My code follows the style guidelines
• My code passes tests

[light-and-ray]

Maybe someone wants to change this symlink before reload ui. It's more logical to leave the original paths without symlink resolving

Why does this bug happen? Why does forge know about the original SD directory?

[light-and-ray]

Hmm, dat upscales doesn't have this problem

Upd it doesn't have problem because it doesn't have cmd flag. Also should be added

I will make a new PR

[light-and-ray]

Ooops, I misunderstood and did the same thing 🤣

[light-and-ray]

Sorry for this misunderstanding. I left only add --dat-models-path cmd flag. #15039

[clayne]

Thanks for this, I'm definitely being bitten by the multiple upscaler entries issue (and also use a symlink for models -> <some-other-location>) in 1.8.0rc.

Related notes: https://bugs.python.org/issue39090

[clayne]

@light-and-ray So this is afflicting me again after I rearranged some upscaler directories to be more compatible with a ComfyUI install using the same shared model directory.

Here's my layout:

Base model path is a symlink to a shared path which is shared by various UIs:

clayne@sv590:/f/stablediffusion/stable-diffusion-webui (dev=) $ ls -lad models
lrwxrwxrwx 1 clayne None 16 Mar 24 12:07 models -> ../shared/models

Within that shared directory, the A1111 specific upscaler directories are symlinked into a shared upscalers directory:

clayne@sv590:/f/stablediffusion/shared/models $ ls -la | grep upscalers
lrwxrwxrwx  1 clayne None  9 Mar 18 17:15 ESRGAN -> upscalers
lrwxrwxrwx  1 clayne None  9 Mar 18 17:15 GFPGAN -> upscalers
lrwxrwxrwx  1 clayne None 14 Mar 20 14:32 LDSR -> upscalers/ldsr
lrwxrwxrwx  1 clayne None  9 Mar 18 17:15 RealESRGAN -> upscalers
lrwxrwxrwx  1 clayne None  9 Mar 18 17:15 ScuNET -> upscalers
lrwxrwxrwx  1 clayne None  9 Mar 18 17:15 SwinIR -> upscalers
drwxr-xr-x+ 1 clayne None  0 Mar 23 22:50 upscalers

In A1111, this results in the following behavior:

vs Comfy:

Previously, this "worked" even with my stable-diffusion-webui/models -> ../shared/models symlink, but the second I converted the various upscaler directories to symlinks is when this bug resurfaced.

Edit: so it looks like absolute() should be fine here as it's simply resolving the directory without completely following the symlinks to their destination (as opposed to something like readlink -f):

>>> Path('models/RealESRGAN').absolute()
PosixPath('/f/stablediffusion/stable-diffusion-webui-1-8-0-rc/models/RealESRGAN')

vs

>>> Path('models/RealESRGAN').resolve()
PosixPath('/f/stablediffusion/shared/models/upscalers')

Not sure why I'm seeing dupe entries again though.

[catboxanon]

Because you're symlinking an entire folder of upscalers and not separating them by type, they're going to appear several times since they'll be picked up for each architecture. That's why your list now contains 3 entries for each file. ComfyUI only provides a single upscale_models folder which is why it doesn't have this problem.

[clayne]

Because you're symlinking an entire folder of upscalers and not separating them by type, they're going to appear several times since they'll be picked up for each architecture. That's why your list now contains 3 entries for each file. ComfyUI only provides a single upscale_models folder which is why it doesn't have this problem.

I understand the likely mechanism of what's happening but this still seems like something trivial to fix on the code side by use of a simple hash table to prevent dupes. For now I guess I'll just symlink into upscaler specific directories and hope ComfyUI handles recursively finding them.