FilenameGenerator Sampler Scheduler #15581
Merged
+29
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the behavior of the FilenameGenerator pattern
[sampler]
was change in 1.9 due tothis PR add an adds two new FilenameGenerator pattern
[sampler_scheduler]
this is basically the old behavior
{Sampler} {Scheduler}
ieDPM++ 2M Karras
[scheduler]
only
{Scheduler}
part ieKarras
note for some samplers automatic scheduler I wasn't able to find a corresponding type and so they will be output as
Automatic
not sure if they should be displayed as
blank
Debate
should the old behavior of
[sampler]
be restoredif so
[sampler_scheduler]
will be renamed to[sampler]
and[sampler]
rename to[sampler_only]
or something similerreason to restore: preserve old behavior
reason not to restore:
[sampler]
and[sampler_scheduler]
is more straightforChecklist: