Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilenameGenerator Sampler Scheduler #15581

Merged
merged 1 commit into from Apr 21, 2024

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Apr 20, 2024

Description

the behavior of the FilenameGenerator pattern [sampler] was change in 1.9 due to

this PR add an adds two new FilenameGenerator pattern

  • [sampler_scheduler]
    this is basically the old behavior {Sampler} {Scheduler} ie DPM++ 2M Karras
  • [scheduler]
    only {Scheduler} part ie Karras

note for some samplers automatic scheduler I wasn't able to find a corresponding type and so they will be output as Automatic
not sure if they should be displayed as blank

Debate

should the old behavior of [sampler] be restored
if so [sampler_scheduler] will be renamed to [sampler] and [sampler] rename to [sampler_only] or something similer

reason to restore: preserve old behavior
reason not to restore: [sampler] and [sampler_scheduler] is more straightfor

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit 3810413 into dev Apr 21, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the FilenameGenerator-sampler-scheduler branch April 21, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants