Add the "bundled" string as the shorthash for bundled textual inversions #15674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons. This will thus show "bundled" in the info text when such a TI is applied, providing the user with feedback that the bundled TI was used. Otherwise, there's no such feedback.
|
The automated check seems to have flaked out because of an earlier PR I closed; this PR is targeting the dev branch. |
|
you can amend the last commit then fore push if you want to remove the ❌ |
|
Alternate implementation in #15679 so withdrawing this PR. Thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will thus show "bundled" in the info text for a textual inversion where the shorthash would normally be shown when a bundled TI is applied. This provides the user with feedback that a TI was used; otherwise there would be no such feedback.
I am unclear if setting such a shorthash will have other knock-on effects; all I did was run a generation to show that it showed up correctly, and the tests.
Checklist: