Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sampler scheduler autocorrection warning #16054

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Jun 20, 2024

Description

fix unnecessary sampler scheduler autocorrection warning

from Discussions post

user has reported erroneous scheduler autocorrection warning

essentially under certain circumstances such as
sampler DPM++ 2M + schedule Karras they will see the sampler scheduler autocorrection warning

this is because of default schedule for DPM++ 2M is Karras, and so the retruned schedule of get_sampler_and_scheduler() will be Automatic Karras
this triggers a false warning because Automatic != Karras

functionality wise It's harmless but it does confuse people

fix:
add new a arg convert_automatic: boolto get_sampler_and_scheduler() that disables revert back to Automatic if it's the default scheduler for the selected sampler behavior


additional unrelated change that I decide to throw in

Checklist:

@w-e-w w-e-w force-pushed the fix-Sampler-Scheduler-autocorrection-warning branch 2 times, most recently from 4e8fb4b to 82ca10f Compare June 21, 2024 03:12
@w-e-w w-e-w force-pushed the fix-Sampler-Scheduler-autocorrection-warning branch from 82ca10f to 0f40c4b Compare June 21, 2024 03:14
@BurnZeZ
Copy link

BurnZeZ commented Jun 22, 2024

Yeah, it makes it seem like it’s switching to a different scheduler.

@AUTOMATIC1111 AUTOMATIC1111 merged commit ace00a1 into dev Jul 6, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the fix-Sampler-Scheduler-autocorrection-warning branch July 6, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants