Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sampler scheduler autocorrection warning #16054

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Jun 20, 2024

Description

fix unnecessary sampler scheduler autocorrection warning

from Discussions post

user has reported erroneous scheduler autocorrection warning

essentially under certain circumstances such as
sampler DPM++ 2M + schedule Karras they will see the sampler scheduler autocorrection warning

this is because of default schedule for DPM++ 2M is Karras, and so the retruned schedule of get_sampler_and_scheduler() will be Automatic Karras
this triggers a false warning because Automatic != Karras

functionality wise It's harmless but it does confuse people

fix:
add new a arg convert_automatic: boolto get_sampler_and_scheduler() that disables revert back to Automatic if it's the default scheduler for the selected sampler behavior


additional unrelated change that I decide to throw in

Checklist:

@w-e-w w-e-w force-pushed the fix-Sampler-Scheduler-autocorrection-warning branch 2 times, most recently from 4e8fb4b to 82ca10f Compare June 21, 2024 03:12
@w-e-w w-e-w force-pushed the fix-Sampler-Scheduler-autocorrection-warning branch from 82ca10f to 0f40c4b Compare June 21, 2024 03:14
@BurnZeZ
Copy link

BurnZeZ commented Jun 22, 2024

Yeah, it makes it seem like it’s switching to a different scheduler.

@AUTOMATIC1111 AUTOMATIC1111 merged commit ace00a1 into dev Jul 6, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the fix-Sampler-Scheduler-autocorrection-warning branch July 6, 2024 07:11
@DotPoker2
Copy link

DotPoker2 commented Jul 20, 2024

i'm still getting this warning even after newest patch, i know Euler wasn't fixed, but it's the main one i use, and to see it still have the autocorrect issue is beyond annoying
Screenshot (136)
Screenshot (137)

@w-e-w
Copy link
Collaborator Author

w-e-w commented Jul 21, 2024

i'm still getting this warning even after newest patch, i know Euler wasn't fixed, but it's the main one i use, and to see it still have the autocorrect issue is beyond annoying

@DotPoker2 send me a screenshort of your UI before you click generate
I want to see you sampler scheduler inputs
image

from what I can see

Sampler Scheduler autocorrection: "Euler a" -> "Euler a", "None" -> "Automatic"'

it is is working as intended
None is not a valid scheduler name and so autocorrection change it to Automatic


try disabling all extensions for now
image
I'm suspecting that you're using an extension which does not have scheduler input
if thisis the case if it weren't for the autocorrect, it would just error and not continue on

@DotPoker2
Copy link

DotPoker2 commented Jul 21, 2024

i'm still getting this warning even after newest patch, i know Euler wasn't fixed, but it's the main one i use, and to see it still have the autocorrect issue is beyond annoying

@DotPoker2 send me a screenshort of your UI before you click generate I want to see you sampler scheduler inputs image

from what I can see

Sampler Scheduler autocorrection: "Euler a" -> "Euler a", "None" -> "Automatic"'

it is is working as intended None is not a valid scheduler name and so autocorrection change it to Automatic

try disabling all extensions for now image I'm suspecting that you're using an extension which does not have scheduler input if thisis the case if it weren't for the autocorrect, it would just error and not continue on

here
Screenshot 2024-07-21 140728
Screenshot (138)

@w-e-w
Copy link
Collaborator Author

w-e-w commented Jul 21, 2024

did you try disabling all extensions?

@DotPoker2
Copy link

did you try disabling all extensions?

i'll try it, but i doubt that's the solution, will update you if it works or not.

@w-e-w
Copy link
Collaborator Author

w-e-w commented Jul 21, 2024

btw https://github.com/KohakuBlueleaf/LyCORIS.git is not an extension
at best it does nothing at worst it break stuff
remove it

@DotPoker2
Copy link

btw https://github.com/KohakuBlueleaf/LyCORIS.git is not an extension at best it does nothing at worst it break stuff remove it

right

@DotPoker2
Copy link

DotPoker2 commented Jul 21, 2024

btw https://github.com/KohakuBlueleaf/LyCORIS.git is not an extension at best it does nothing at worst it break stuff remove it

right

so, if i don't get the warning, can i slowly add back my extensions one at a time to see if one of them is causing the error?
Screenshot (142)

@w-e-w
Copy link
Collaborator Author

w-e-w commented Jul 21, 2024

so, if i don't get the warning, can i slowly add back my extensions one at a time to see if one of them is causing the error?

yes
and if you found out which one is the cause tell me

@DotPoker2
Copy link

DotPoker2 commented Jul 21, 2024

so, if i don't get the warning, can i slowly add back my extensions one at a time to see if one of them is causing the error?

yes

so far, CivitAi extension, nor Regional Prompter, aren't the culprits causing the error, i'll reply more after i test the other's.
Lycoris isn't it either, but i'm leaving it off now. Lora Masks and 3d open pose editor and Additional Networks aren't the cause either. Nope not controlnet.
Adetailer itself isn't the cause, i'm wondering if it's a model i use in Adetailer.
It's a model i use in Adetailer, https://civitai.com/models/150925/eyes-detection-adetailer

@DotPoker2
Copy link

DotPoker2 commented Jul 21, 2024

so, if i don't get the warning, can i slowly add back my extensions one at a time to see if one of them is causing the error?

yes and if you found out which one is the cause tell me

@w-e-w

Adetailer itself isn't the cause, i'm wondering if it's a model i use in Adetailer.
Screenshot (144)
It's a model i use in Adetailer, https://civitai.com/models/150925/eyes-detection-adetailer
but when i use the default eye model i get this,
Screenshot (145)
huh, even Face_yolov8n.pt is giving me the same error,
Screenshot (146)

@w-e-w
Copy link
Collaborator Author

w-e-w commented Jul 21, 2024

since this is the case report this is to adetailer, somewhere in their code they they forgot to specify scheduler type
autocorrection is working correctly but they should not rely on it

@DotPoker2
Copy link

since this is the case report this is to adetailer, somewhere in their code they they forgot to specify scheduler type autocorrection is working correctly but they should not rely on it

it seems to be the Adetailer yolo models that are causing the error for the sampler scheduler error.

@DotPoker2
Copy link

since this is the case report this is to adetailer, somewhere in their code they they forgot to specify scheduler type autocorrection is working correctly but they should not rely on it

would this count as to whats causing the error?
Screenshot (147)

@w-e-w
Copy link
Collaborator Author

w-e-w commented Jul 21, 2024

would this count as to whats causing the error?

yes, case closed

@DotPoker2
Copy link

would this count as to whats causing the error?

yes, case closed

ugh, so how do you plan to get this fixed? does this now go to a1111 and Bing-su to resolve this?

@w-e-w
Copy link
Collaborator Author

w-e-w commented Jul 21, 2024

ugh, so how do you plan to get this fixed? does this now go to a1111 and Bing-su to resolve this?

I don't plan on anything, and there is nothing I can do even if I want to
this is an issue from adetailer, so it needs to be fix by adetailer
and as you have shown above that the issue has already been fixed Bing-su in the adetailer's dev branch

if you wanted to be fixed now, you need to switch to adetailer dev branch

if you do you are also open yourself to instability of dev branch

or you can wait until Bing-su pushes the fix to adetailer main branch

@DotPoker2
Copy link

ugh, so how do you plan to get this fixed? does this now go to a1111 and Bing-su to resolve this?

I don't plan on anything, and there is nothing I can do even if I want to this is an issue from adetailer, so it needs to be fix by adetailer and as you have shown above that the issue has already been fixed Bing-su in the adetailer's dev branch

if you wanted to be fixed now, you need to switch to adetailer dev branch

if you do you are also open yourself to instability of dev branch

or you can wait until Bing-su pushes the fix to adetailer main branch

Screenshot (148)
already am in dev branch

@w-e-w
Copy link
Collaborator Author

w-e-w commented Jul 21, 2024

no you're not
go learn how to use git to switch branch
or the better option is to just wait until adetailer updates
because you can break stuff if you don't do what you're doing

@DotPoker2
Copy link

DotPoker2 commented Jul 21, 2024

no you're not go learn how to use git to switch branch or the better option is to just wait until adetailer updates because you can break stuff if you don't do what you're doing

i've used adetailer for three months, i think i know what i'm doing.
I'll wait till it updates, then i'll re-use it.

@w-e-w
Copy link
Collaborator Author

w-e-w commented Jul 21, 2024

i've used adetailer for three months, i think i know what i'm doing.

using the software and the development the software is completely different thing

when you say

already am in dev branch

and then share a screenshot of github
it is basically like you said that you went to Antarctica by clicking on Google Maps
visiting a website doesn't suddenly change your computer's software version

if you want to switch branch you need to have a basic understanding of how to use git

@DotPoker2
Copy link

DotPoker2 commented Jul 21, 2024

i've used adetailer for three months, i think i know what i'm doing.

using the software and the development the software is completely different thing

when you say

already am in dev branch

and then share a screenshot of github it is basically like you said that you went to Antarctica by clicking on Google Maps visiting a website doesn't suddenly change your computer's software version

if you want to switch branch you need to have a basic understanding of how to use git

I updated the branch of Adetailer to dev, no issues with anything, the error is gone, sorry @w-e-w for the words.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants