allow styles.csv to be symlinked or mounted in docker #9334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need this |
AUTOMATIC1111
approved these changes
Apr 29, 2023
AbdBarho
added a commit
to AbdBarho/stable-diffusion-webui-docker
that referenced
this pull request
May 4, 2023
Follow up to #386 after AUTOMATIC1111/stable-diffusion-webui#9334 has been merged. Closes #435
Jordan-Lambda
pushed a commit
to Jordan-Lambda/lambda-cloud-stable-diffusion-2.0-webui-easy
that referenced
this pull request
Aug 2, 2023
Follow up to AbdBarho#386 after AUTOMATIC1111/stable-diffusion-webui#9334 has been merged. Closes AbdBarho#435
cloudaxes
pushed a commit
to cloudaxes/stable-diffusion-webui-docker
that referenced
this pull request
Sep 6, 2023
Follow up to AbdBarho#386 after AUTOMATIC1111/stable-diffusion-webui#9334 has been merged. Closes AbdBarho#435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In stable-diffusion-webui-docker we want to mount the styles.csv to the host system to persist saved styles upon container restart. This is currently difficult as the file is moved around to prevent data loss on write operations.
The file is moved and thus symlinks won't keep up anymore, a direct docker bind mount doesn't work as well, as now the write process failes with
device or resource busy, as a mounted file cannot be moved.Further readings on the PR over in stable-diffusion-webui-docker: AbdBarho/stable-diffusion-webui-docker#386
My PR is a simple proposal to work around those problems. Surely not bulletproof, but I wanted to have a quick sample showing what would be a solution on our end, any feedback very welcome, I hope we can work on a solution together :)