Improve handling of the fenced code blocks #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolange
force-pushed
the
improve_fence_code_parsing
branch
from
aab4581
to
feb6cea
Compare
nolange
force-pushed
the
improve_fence_code_parsing
branch
from
feb6cea
to
f1e8fdc
Compare
Supports whitespace after the fence. ex:
``` plantuml
stuff
```
Support more than 3 ticks or tildes for code blocks, this is still
only a part of the variations in the wilds [1]
Finds the correct matching ending fence by using identation,
this required adding some more groups to the regexp and
the option MULTILINE. ex.
```` plantuml
stuff containing ```
````
[1] - https://pandoc.org/MANUAL.html#fenced-code-blocks
Closes: AVATEAM-IT-SYSTEMHAUS#34
nolange
force-pushed
the
improve_fence_code_parsing
branch
from
f1e8fdc
to
5561213
Compare
Use a fixed regex to match all fence blocks, not just the ones that are modified by this plugin. de-indent the code block before processing. This will avoid having wrong matches within a fenced block. ex: ```` Hey, this is just regular text, presenting a plantuml code block. ``` plantuml @startuml ... @enduml ``` ```` De-indentind the code is necessary if the code block is in a structural element like a list. (Apart from being not correct, handling from_file_prefix did not work in that case)
nolange
force-pushed
the
improve_fence_code_parsing
branch
from
5561213
to
5d7b126
Compare
|
@b-bittner : All done and ready from my side |
|
Ping? |
2 tasks
oniboni
changed the base branch from
main
to
58-improve-handling-of-the-fenced-code-blocks
oniboni
merged commit 233a3ef
into
AVATEAM-IT-SYSTEMHAUS:58-improve-handling-of-the-fenced-code-blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports whitespace after the fence. ex:
Support more than 3 ticks or tildes for code blocks, this is still only a part of the variations in the wilds [1]
Finds the correct matching ending fence by using identation, this required adding some more groups to the regexp and the option MULTILINE. ex.
[1] - https://pandoc.org/MANUAL.html#fenced-code-blocks
Closes: #34