-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/image handling #46
Refactoring/image handling #46
Conversation
* place referenced image files next to page * take metadata into account for image name generateion * update to mkdocs 1.4 plugin config * remove temp dir and download dir * deprecate `DownloadImages` -> `HttpMethod='POST'` realizes this functionality as well * deprecate `DownloadDir` option to get rid of relative and absolute path issues * move kroki response handling to kroki client * add type hints
…for compatibility
We have tested this PR and can confirm that it fixes the downloaded image URLs. We use this plugin in our organization and would be grateful if you released a new version of the plugin containing this fix. |
I can also confirm this plugin works for us. Would be nice to get this merged so we can switch from our fork to the upstream release. |
@b-bittner any hopes of getting this in please? |
Just an FYI here: This code change makes the plugin require a higher Python version than 3.8. Our techdocs fail to render with 3.8, but work with 3.10: Failed example:
|
Thanks for your hint, just updated the dependencies. |
fix: downloaded image handling
DownloadImages
->HttpMethod='POST'
realizes thisfunctionality as well
DownloadDir
option to get rid of relative and absolutepath issues
Fixes #11, fixes #32, fixes #39, fixes #41