Edited PPP #216
Merged
Edited PPP #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed: included prefix mat_no and nusid in argmultimap for addstudentcommandparser fixed: added issameperson() in Student which is called in contains in UniquePersonList which is called in addstudent/hasstudent in application, changed message_duplicate_student to reflect the new logic changed: error messages (invalid ... in ...) to for better comprehension changed: command usage messages for better comprehension fixed: included conditional in application.setstudent() that does nothing if editedstudent and target are equal to avoid bug where student reference is changed in uniquepersonlist when the same student is added and removed fixed: partialinputparsertest where by bob and amy had the same nusnetid and matricnums
fixed: changed assignment/tutname/eventname regex fixed: display not a valid command, removed from Finder.java fixed: optional[] no longer printed for optional fields in student.toString() fixed: duplicateevents error not shown in console for addEventCommand
fixed: import command whereby no error is shown in console when import https://nusmods.com/timetable/sem-1/share? is inputted changed: import command message changed: tutname regex to accept non white space characters
changed: displayassignmentscommand message usage - please update user guide changed: studentnotfoundexception message in setassignmentscorecommand fixed: did not throw error when setscore command is called for a student not in the tutorial
Fixed storage for semStart
fixed: Error not thrown in application when application is changed but semstart is null fixed: Error not thrown when invalid time is inputted for addTutorial (9999) fixed: SuggestedCommands not set to an empty list when deleteSuggestedCommands is called - causes error to be thrown in terminal when index is inputted after suggestedCommand.execute() throws an error
Ellieyee
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.