Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: refactor of Profile Component and Tests #208

Merged
merged 6 commits into from Nov 10, 2019

Conversation

Q-gabe
Copy link

@Q-gabe Q-gabe commented Nov 9, 2019

Changes:

  • Refactored most of the Profile component to abide better programming standards.
  • Added ProfileUtil to help with extracting the assembly of Profile .txt generation.
  • Generated .txt files of Profile will be found in generated_profiles as usual, with additional read-only access.
  • Unit Tests added for ProfileCommand, GenerateProfileCommand, ProfileUtil, StringUtil.

@Q-gabe Q-gabe self-assigned this Nov 9, 2019
@Q-gabe Q-gabe added this to the v1.4 milestone Nov 9, 2019
@gachia gachia self-requested a review November 10, 2019 03:26
Copy link

@gachia gachia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Wingedevil Wingedevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Q-gabe Q-gabe merged commit 5f2219e into AY1920S1-CS2103T-F12-2:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants