docs: update UG and PPP #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wingedevil
added
type.Bug
|
Please resolve branch conflicts |
Q-gabe
approved these changes
Nov 10, 2019
| String aliasUsage2 = "TEST ADD n/John Smith p/91234567 e/john@smith.co.uk " | ||
| + "a/12 Downing St Westminster, London SW1A 2AD, UK"; | ||
| String aliasUsageExpected2 = "add n/John Smith p/91234567 e/john@smith.co.uk " | ||
| + "a/12 Downing St Westminster, London SW1A 2AD, UK"; | ||
|
|
There was a problem hiding this comment.
Test Aliases could perhaps be set as a static variable in a separate TestUtil class actually. Something like TypicalAliases() could be useful for future extension of the alias feature.
|
|
||
| expectedModel.removeAlias(alias2.toLowerCase()); | ||
| assertCommandSuccess(new UnaliasCommand(alias2), model, | ||
| String.format(UnaliasCommand.MESSAGE_SUCCESS, alias2.toLowerCase()), expectedModel); | ||
| } |
There was a problem hiding this comment.
Comments for each equivalence partition would be a nice addition for each individual assertCommandSuccess() call.
| @@ -54,6 +58,7 @@ public void setup(String aliases) { | |||
| * </ul> | |||
| */ | |||
| public void show() { | |||
| logger.fine("Showing list of aliases."); | |||
… into branch-alias-command
SQwQ
approved these changes
Nov 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.