Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeleteNoteCommandTest #107

Merged
merged 24 commits into from
Oct 20, 2019
Merged

Add DeleteNoteCommandTest #107

merged 24 commits into from
Oct 20, 2019

Conversation

shiweing
Copy link

No description provided.

@shiweing
Merge pull request #2 from AY1920S1-CS2103T-F12-3/master
f03339c 
[Likai] Update AboutUs.adoc for team members to commit
@shiweing
Merge pull request #3 from AY1920S1-CS2103T-F12-3/master
59b651d 
[Yehezkiel] Add team members' About Us
@shiweing
Merge pull request #4 from AY1920S1-CS2103T-F12-3/master
7133161 
Update developer guide
Update About us
Refractor package name from seedu.address to tagline
@shiweing
Add changes from team repo (#5)
7acba76 
* Refactor package name from 'seedu.address' to 'tagline'

* Update mainClassName in build.gradle
@shiweing
Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master
d6dd340 
* Refactor package name from 'seedu.address' to 'tagline'

* Update mainClassName in build.gradle

* Added Contact Command + Basic Commands to UserGuide.adoc

* Update mentions of AddressBook to TagLine

* Update AboutUs.adoc

* Add more use cases to Developer Guide

* Update team name
@shiweing
Merge and resolve conflicts from upstream
1e6da83
@shiweing
Add newline after EOF for README and AboutUs
e0a4438
@shiweing
Merge pull request #9 from AY1920S1-CS2103T-F12-3/main
beda0a8
@shiweing
Fix Yehez image name
7f7a6f7
@shiweing
Merge PR #10 from AY1920S1-CS2103T-F12-3/main
aebd5fd 
* Update Prof name in AboutUs (#35)

#21

* Rename Yehezkiel image (#36)

* Fix typos in Developer Guide and User Guide (#37)
@shiweing
Updates from upstream (#14)
72ed368 
* Add chat pane to GUI (#9)

* Refactor result pane view (AY1920S1-CS2103T-F12-3#42)

* Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46)

* Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43)

* Update contact parser (AY1920S1-CS2103T-F12-3#62)

* Rename person to contact (AY1920S1-CS2103T-F12-3#65)
@shiweing
Fix merge conflict
8f6c38b
@shiweing
Fix merge conflicts from upstream
a6665fd
@shiweing
Fix merge conflicts
3fa5eb6
@shiweing
Merge remote-tracking branch 'upstream/master'
ff2154d
@shiweing
Fix merge conflict from pulling from upstream
feca022
@shiweing
Add missing files to master from upstream
49b4ac9
@shiweing
Remove dummy view
ade641a
@shiweing
Add valid note id tests for DeleteNoteCommand
00f90b0
@shiweing
Implement invalid note id test for DeleteNoteCommand
a03ad08
@shiweing
Add findNote() in Model
abe9652
@shiweing
Implement DeleteNoteCommand execution with model.findNote()
22a29f1
@shiweing
Fix checkstyle errors
6caa677
@shiweing
Fix ModelStub error
36b6984
tanlk99
tanlk99 approved these changes Oct 20, 2019
View reviewed changes
Copy link

@tanlk99 tanlk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to have a findNote method similar to findContact. Approved and merged.

@tanlk99 tanlk99 merged commit f79e946 into AY1920S1-CS2103T-F12-3:master Oct 20, 2019
@shiweing shiweing deleted the test/delete-note branch October 23, 2019 09:30
@nus-se-bot nus-se-bot mentioned this pull request Oct 25, 2019
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanlk99 tanlk99 tanlk99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shiweing @tanlk99