forked from nus-cs2103-AY1920S1/addressbook-level3
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement note filtering #140
Merged
Yehezkiel01
merged 39 commits into
AY1920S1-CS2103T-F12-3:master
from
shiweing:feature/filter
Oct 31, 2019
Merged
Implement note filtering #140
Yehezkiel01
merged 39 commits into
AY1920S1-CS2103T-F12-3:master
from
shiweing:feature/filter
Oct 31, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Likai] Update AboutUs.adoc for team members to commit
[Yehezkiel] Add team members' About Us
Update developer guide Update About us Refractor package name from seedu.address to tagline
* Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle
* Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name
* Add chat pane to GUI (#9) * Refactor result pane view (AY1920S1-CS2103T-F12-3#42) * Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46) * Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43) * Update contact parser (AY1920S1-CS2103T-F12-3#62) * Rename person to contact (AY1920S1-CS2103T-F12-3#65)
Add DeleteNoteCommandTest
* Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (AY1920S1-CS2103T-F12-3#108)
* Update Dev Guide Proposed Component (AY1920S1-CS2103T-F12-3#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (AY1920S1-CS2103T-F12-3#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (AY1920S1-CS2103T-F12-3#124)
Tests for delete note Tests for edit note XML for DG Group feature
Test for delete note Test for edit note XML for DG Group feature
e0031374
approved these changes
Oct 29, 2019
tanlk99
reviewed
Oct 29, 2019
Updates from upstream
Remove tag id
Updates from upstream
Yehezkiel01
approved these changes
Oct 31, 2019
Yehezkiel01
approved these changes
Oct 31, 2019
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes multi tag filtering
TODO: Tests for note list command
Fixes #92
Fixes #112