Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement note filtering #140

Merged
merged 39 commits into from
Oct 31, 2019

Conversation

shiweing
Copy link

@shiweing shiweing commented Oct 29, 2019

Includes multi tag filtering
TODO: Tests for note list command
Fixes #92
Fixes #112

[Likai] Update AboutUs.adoc for team members to commit
[Yehezkiel] Add team members' About Us
Update developer guide
Update About us
Refractor package name from seedu.address to tagline
* Refactor package name from 'seedu.address' to 'tagline'

* Update mainClassName in build.gradle
* Refactor package name from 'seedu.address' to 'tagline'

* Update mainClassName in build.gradle

* Added Contact Command + Basic Commands to UserGuide.adoc

* Update mentions of AddressBook to TagLine

* Update AboutUs.adoc

* Add more use cases to Developer Guide

* Update team name
* Update Prof name in AboutUs (#35)

#21

* Rename Yehezkiel image (#36)

* Fix typos in Developer Guide and User Guide (#37)
* Add chat pane to GUI (#9)

* Refactor result pane view (AY1920S1-CS2103T-F12-3#42)

* Implement view switching in GUI (AY1920S1-CS2103T-F12-3#46)

* Refactor Contact Command Parsers (AY1920S1-CS2103T-F12-3#43)

* Update contact parser (AY1920S1-CS2103T-F12-3#62)

* Rename person to contact (AY1920S1-CS2103T-F12-3#65)
* Refactor TagList to UniqueTagList and TagBook to follow structure

Full changelist:
- Refactor TagList to UniqueTagList
- Add TagBook to implement ReadOnlyTagBook
- Change storage to use ReadOnlyTagBook instead of TagList
- Include new definition of equality for Tags (all fields equal except ID)
- Standardize UniqueXXXXList method naming convention

* Update architecture diagrams, UI structure, user stories, use cases and NFRs (AY1920S1-CS2103T-F12-3#108)
* Update Dev Guide Proposed Component (AY1920S1-CS2103T-F12-3#123)

* DG changes in diagram to update future proposed implementation

* clearer docs

* added linebreaks

* line breaks

* linebreak

* formatting

* Refactor ResultPane into a separate class (AY1920S1-CS2103T-F12-3#103)

* Update AboutUs.adoc for team members to commit

* Add a newline in AboutUs.adoc

* Add more use cases to Developer Guide

* Fix missing endline

* Update various docs to display TagLine

* Add placeholder image

* Fix minor typo in user guide

* Update Tagline to TagLine

* Update team name

* Fix some typos in user guide and developer guide

* Add some tests and remove ContactCard index

* Add new test to NoteListCardTest

* Remove magic literal in NoteListCard

* Fix variable declaration order

* Refactor ResultPane into a separate class

* Add missing Javadoc

* Add note filtering implementation to DG (AY1920S1-CS2103T-F12-3#124)
Tests for delete note
Tests for edit note
XML for DG
Group feature
Test for delete note
Test for edit note
XML for DG
Group feature
@shiweing shiweing changed the title Add logic for note filtering with tags [WIP] Add logic for note filtering with tags Oct 30, 2019
@shiweing shiweing changed the title [WIP] Add logic for note filtering with tags Implement note filtering Oct 31, 2019
@Yehezkiel01 Yehezkiel01 merged commit ef2cf74 into AY1920S1-CS2103T-F12-3:master Oct 31, 2019
@shiweing shiweing deleted the feature/filter branch November 5, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide filter by multi tag as proposed feature in Developer Guide Add filter by tag feature
4 participants