Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SampleDataUtil and One Potential Bug/fix #153

Merged
merged 19 commits into from
Oct 31, 2019

Conversation

e0031374
Copy link

tl;dr
Bug Replication steps:

  1. group find bts
  2. contact delete [some bts contactid]

this PR attempts to "fix" it by making contact delete always display all contacts in addresbook after it is done

==== long version ====

Basically, the original AB3 behaviour was that if you did the following

  1. contact find something
  2. contact delete 3

after these two steps, contact list will still show whatever the list was after step 1 just without the deleted contact instead of the full addressbook list of contacts without the deleted contact

this may cause the unintended problems since groups is now sharing this part
bug replication:

  1. group find bts
  2. contact delete [some bts contactid]

and you will find that it reverts to contact view but filtered to only show contacts in bts less the deleted contact. (and without the group panel)

so one way around this is to force "contact delete" to always show the full addressbook list after deleting, much like how adding a new contact does right now. this would bring contact delete in line with behaviour with "group delete"
but am i missing something?

e0031374 and others added 19 commits October 8, 2019 01:02
Merge before trying to start on Group contacts
@tanlk99
Copy link

tanlk99 commented Oct 31, 2019

tl;dr
Bug Replication steps:

  1. group find bts
  2. contact delete [some bts contactid]

this PR attempts to "fix" it by making contact delete always display all contacts in addresbook after it is done

==== long version ====

Basically, the original AB3 behaviour was that if you did the following

  1. contact find something
  2. contact delete 3

after these two steps, contact list will still show whatever the list was after step 1 just without the deleted contact instead of the full addressbook list of contacts without the deleted contact

this may cause the unintended problems since groups is now sharing this part
bug replication:

  1. group find bts
  2. contact delete [some bts contactid]

and you will find that it reverts to contact view but filtered to only show contacts in bts less the deleted contact. (and without the group panel)

so one way around this is to force "contact delete" to always show the full addressbook list after deleting, much like how adding a new contact does right now. this would bring contact delete in line with behaviour with "group delete"
but am i missing something?

No that is indeed a problem. Thanks for the correction.

@tanlk99 tanlk99 merged commit 726b397 into AY1920S1-CS2103T-F12-3:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants