-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SampleDataUtil and One Potential Bug/fix #153
Update SampleDataUtil and One Potential Bug/fix #153
Conversation
User Guide Update
Merge before trying to start on Group contacts
Update To Shiwei's PR
Milestone v1.2 Update
Post Refactor of Tags
Update Dev Guide 1
Update From Upstream
Add tests fro delete note command (AY1920S1-CS2103T-F12-3#133)
Implement Group Features (AY1920S1-CS2103T-F12-3#135)
Add views to display groups (AY1920S1-CS2103T-F12-3#138)
Merge From Upstream
Merge from Upstream
No that is indeed a problem. Thanks for the correction. |
tl;dr
Bug Replication steps:
this PR attempts to "fix" it by making contact delete always display all contacts in addresbook after it is done
==== long version ====
Basically, the original AB3 behaviour was that if you did the following
after these two steps, contact list will still show whatever the list was after step 1 just without the deleted contact instead of the full addressbook list of contacts without the deleted contact
this may cause the unintended problems since groups is now sharing this part
bug replication:
and you will find that it reverts to contact view but filtered to only show contacts in bts less the deleted contact. (and without the group panel)
so one way around this is to force "contact delete" to always show the full addressbook list after deleting, much like how adding a new contact does right now. this would bring contact delete in line with behaviour with "group delete"
but am i missing something?