Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Refactor of Tags #7

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Conversation

e0031374
Copy link
Owner

some standardization of method namings in unique something list

shiweing and others added 2 commits October 20, 2019 22:06
* Add changes from team repo (#5)

* Refactor package name from 'seedu.address' to 'tagline'

* Update mainClassName in build.gradle

* Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master

* Refactor package name from 'seedu.address' to 'tagline'

* Update mainClassName in build.gradle

* Added Contact Command + Basic Commands to UserGuide.adoc

* Update mentions of AddressBook to TagLine

* Update AboutUs.adoc

* Add more use cases to Developer Guide

* Update team name

* Add newline after EOF for README and AboutUs

* Fix Yehez image name

* Merge PR #10 from AY1920S1-CS2103T-F12-3/main

* Update Prof name in AboutUs (#35)

#21

* Rename Yehezkiel image (#36)

* Fix typos in Developer Guide and User Guide (#37)

* Updates from upstream (#14)

* Add chat pane to GUI (#9)

* Refactor result pane view (#42)

* Implement view switching in GUI (#46)

* Refactor Contact Command Parsers (#43)

* Update contact parser (#62)

* Rename person to contact (#65)

* Fix merge conflicts from upstream

* Fix merge conflicts

* Add missing files to master from upstream

* Remove dummy view

* Add valid note id tests for DeleteNoteCommand

* Implement invalid note id test for DeleteNoteCommand

* Add findNote() in Model

* Implement DeleteNoteCommand execution with model.findNote()

* Fix checkstyle errors

* Fix ModelStub error
* Update AboutUs.adoc for team members to commit

* Add a newline in AboutUs.adoc

* Add more use cases to Developer Guide

* Fix missing endline

* Update various docs to display TagLine

* Add placeholder image

* Fix minor typo in user guide

* Update Tagline to TagLine

* Update team name

* Fix some typos in user guide and developer guide

* Refactor TagList to UniqueTagList and TagBook to follow structure

Full changelist:
- Refactor TagList to UniqueTagList
- Add TagBook to implement ReadOnlyTagBook
- Change storage to use ReadOnlyTagBook instead of TagList
- Include new definition of equality for Tags (all fields equal except ID)
- Standardize UniqueXXXXList method naming convention
@e0031374 e0031374 merged commit d50a1b8 into e0031374:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants