Skip to content
This repository has been archived by the owner on Apr 28, 2021. It is now read-only.

Link Buy Command to Wallet #99

Merged
merged 4 commits into from
Oct 14, 2019
Merged

Conversation

Raikonen
Copy link

  • Update the Wallet accordingly when Buy Command is executed
  • Add Exception Handling when Wallet has insufficient funds
  • Add a cap to price of food item, i.e. maximum of $5000.00

@jon-chua jon-chua self-assigned this Oct 14, 2019
@jon-chua jon-chua self-requested a review October 14, 2019 11:59
@jon-chua
Copy link
Member

jon-chua commented Oct 14, 2019

Issue found when testing, may be due to parsing of doubles.

Steps to reproduce:

  1. budget 10000 2
  2. add n/Mala Xiang Guo p/0.01 d/Spicy goodness c/Chinese t/Spicy t/Healthy l/University Town o/0800 2000 r/Vegetarian
  3. buy 7 (or whatever that item was) 4 times

The wallet updates to 9999.99, then 9999.98, 9999.97 and then 9999.95 🤔

Other than that issue, lgtm 👍

@Raikonen
Copy link
Author

Okay, fix for this issue will be in the next PR

Issue found when testing, may be due to parsing of doubles.

Steps to reproduce:

  1. budget 10000 2
  2. add n/Mala Xiang Guo p/0.01 d/Spicy goodness c/Chinese t/Spicy t/Healthy l/University Town o/0800 2000 r/Vegetarian
  3. buy 7 (or whatever that item was) 4 times

The wallet updates to 9999.99, then 9999.98, 9999.97 and then 9999.95 🤔

Other than that issue, lgtm 👍

Copy link
Member

@jon-chua jon-chua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, remember to fix the issue above 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants