Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hj compiler #36

Merged
merged 24 commits into from
Oct 10, 2019
Merged

Hj compiler #36

merged 24 commits into from
Oct 10, 2019

Conversation

limhawjia
Copy link

Closes #2

  • Finished individual components for the test executor
  • Finish unit tests for components
  • Renamed packages

@limhawjia
Rename main directory
2b702f3
@limhawjia
Fix failing unit test
417e13b
@limhawjia
Add models for compiler
9de0983
@limhawjia
Create compiler environment
5414d22
@limhawjia
Create tests for environment classes
245e9f7
@limhawjia
Add models for test case and user program
028828f
@limhawjia
Modify model and environment classes
d6cabc8
@limhawjia
Create skeleton for compiler
00f2a37
@limhawjia
Finish compiler and its unit test
455e6b8
@limhawjia
Change compiler error logic
3145320
@limhawjia
Streamline environment
a2fd707
@limhawjia
Create model and skeleton for executor
666a4db
@limhawjia
Create program executor
7a5fee5
@limhawjia
Isolate test for compiler
de8c803
@limhawjia
Add test for compiler utils class
1e38c12
@limhawjia
Create skeleton for executor test
09c32f5
@limhawjia
Change compiler environment to work with packaged java classes
983e0de
@limhawjia
Fix compiler unit test
2cce4c7
@limhawjia
Finish executor and its unit test
c01aa95
@limhawjia
Decouple compiler and environment
e887e34
@limhawjia
Extracted interfaces for compiler and executor
549caf4
@limhawjia
Reorganize packages
2320d48
@limhawjia
Fix checkstyle
067c6e0
@limhawjia limhawjia force-pushed the hj-compiler branch 6 times, most recently from e2524a1 to 151162d Compare October 10, 2019 09:10
zhangj1an
zhangj1an approved these changes Oct 10, 2019
View reviewed changes
Copy link

@zhangj1an zhangj1an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/main/java/com/dukeacademy/AppParameters.java
@@ -1,14 +1,15 @@
package seedu.address;
package com.dukeacademy;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alxkohh
alxkohh approved these changes Oct 10, 2019
View reviewed changes
Copy link

@alxkohh alxkohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alxkohh alxkohh merged commit 743a6a8 into master Oct 10, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 10, 2019
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangj1an zhangj1an zhangj1an approved these changes

@alxkohh alxkohh alxkohh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler
3 participants
@limhawjia @zhangj1an @alxkohh