Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hj integrate logic classes #64

Merged
merged 5 commits into from
Oct 23, 2019
Merged

Hj integrate logic classes #64

merged 5 commits into from
Oct 23, 2019

Conversation

limhawjia
Copy link

closes #60

  • Created new CommandLogic interface to handle command parsing and execution
  • Commands will now have to be registered in the CommandLogic instance to be executed
  • Deleted old commands
  • New commands should use the logic classes to carry out their logic
  • Integrated new Logic classes with the ui
  • Wrote tests for new classes

ning-sy210
ning-sy210 approved these changes Oct 22, 2019
View reviewed changes
Copy link

@ning-sy210 ning-sy210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhangj1an
zhangj1an approved these changes Oct 23, 2019
View reviewed changes
Copy link

@zhangj1an zhangj1an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast game
LGTM

@zhangj1an zhangj1an merged commit 77d6dd7 into master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangj1an zhangj1an zhangj1an approved these changes

@ning-sy210 ning-sy210 ning-sy210 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate new logic classes
3 participants
@limhawjia @zhangj1an @ning-sy210