New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tests for transaction tab #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor notes but looks good!
@@ -32,6 +32,7 @@ public CommandResult execute(Model model, seedu.address.person.model.Model perso | |||
try { | |||
LocalDate deadline = LocalDate.parse(date, DATE_TIME_FORMATTER); | |||
Reimbursement rmb = model.addDeadline(person, deadline); | |||
System.out.println(rmb.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be present? any logging info should go to the logger
@@ -45,6 +45,7 @@ public DeadlineCommand parse(String args, Model personModel) | |||
try { | |||
|
|||
Person person = personModel.getPersonByName(argMultimap.getValue(PREFIX_PERSON).get()); | |||
System.out.println(person.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for this
@@ -42,6 +42,7 @@ public FindCommand parse(String args, Model personModel) | |||
|
|||
try { | |||
Person person = personModel.getPersonByName(argMultimap.getValue(PREFIX_PERSON).get()); | |||
System.out.println(person.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as above
No description provided.