Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user guide/developer guide for Activity command #106

Merged

Conversation

daekoon
Copy link

@daekoon daekoon commented Oct 21, 2019

Context

Behaviour of Activity command was slightly changed during the development. It now uses keyword-based searching instead of doing a complete match with full name, which improves usability. Furthermore, keywords with wrong matches are ignored with a warning message, instead of creating a new Contact object.

Changes

  • Update user guide for Activity command
  • Create section on "Activity class" for Developer Guide
  • Create section on "Create Activity feature" for Developer Guide

@podocarp
Copy link
Member

Hey coverage decreased, I suggest you add tests for your new documentation

@podocarp
Copy link
Member

Ooo coverage is great now, seems like you added tests to your documentation.

@Aulud
Copy link

Aulud commented Oct 22, 2019

Ooo coverage is great now, seems like you added tests to your documentation.

How is this even a thing?

@Aulud Aulud added the documentation Improvements or additions to documentation label Oct 22, 2019
@Aulud Aulud added this to the v1.3 milestone Oct 22, 2019
@daekoon daekoon marked this pull request as ready for review October 23, 2019 20:58
Copy link

@JohnNzj JohnNzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnNzj JohnNzj merged commit 1374580 into master Oct 23, 2019
@JohnNzj JohnNzj deleted the user-guide-developer-guide-update-for-activity-command branch October 23, 2019 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants