Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Meeting #239

Merged
merged 8 commits into from
Nov 6, 2020

Conversation

claraadora
Copy link

No description provided.

@claraadora claraadora added this to the v1.4 milestone Nov 6, 2020
@codecov-io
Copy link

Codecov Report

Merging #239 into master will increase coverage by 1.44%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #239      +/-   ##
============================================
+ Coverage     53.65%   55.10%   +1.44%     
- Complexity      761      789      +28     
============================================
  Files           166      166              
  Lines          3174     3174              
  Branches        352      352              
============================================
+ Hits           1703     1749      +46     
+ Misses         1353     1315      -38     
+ Partials        118      110       -8     
Impacted Files Coverage Δ Complexity Δ
...n/java/seedu/address/model/person/person/Name.java 83.33% <ø> (ø) 7.00 <0.00> (ø)
...dress/model/meeting/meeting/UniqueMeetingList.java 90.00% <0.00%> (+2.00%) 21.00% <0.00%> (+1.00%)
src/main/java/seedu/address/model/UserPrefs.java 84.78% <0.00%> (+2.17%) 15.00% <0.00%> (+1.00%)
.../java/seedu/address/model/meeting/MeetingBook.java 89.28% <0.00%> (+3.57%) 13.00% <0.00%> (+1.00%)
...ddress/logic/parser/meeting/EditCommandParser.java 100.00% <0.00%> (+11.11%) 9.00% <0.00%> (+1.00%)
...u/address/logic/commands/meeting/ClearCommand.java 25.00% <0.00%> (+25.00%) 1.00% <0.00%> (+1.00%)
...edu/address/model/meeting/ModelMeetingManager.java 87.93% <0.00%> (+43.10%) 23.00% <0.00%> (+13.00%)
...ddress/logic/parser/meeting/MeetingBookParser.java 82.35% <0.00%> (+82.35%) 10.00% <0.00%> (+10.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e60d65...4a042ea. Read the comment docs.

Copy link

@MerlinLim MerlinLim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases look good. LGTM

@claraadora claraadora merged commit 2e76f14 into AY2021S1-CS2103T-F11-2:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants