Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Sales Storage feature #96

Merged
merged 7 commits into from
Oct 21, 2020
Merged

Implement Sales Storage feature #96

merged 7 commits into from
Oct 21, 2020

Conversation

yanbingtao
Copy link

  • Sales record can now be saved in the json file.
  • Application can read data from json file to the tCheck when it starts.
  • More test cases are needed, will do it in v1.3 (2nd week).

@yanbingtao yanbingtao added type.Task Something that needs to be done, but not a story, bug, or an epic. priority.High Must do labels Oct 21, 2020
@yanbingtao yanbingtao added this to the v1.3 milestone Oct 21, 2020
@yanbingtao yanbingtao self-assigned this Oct 21, 2020
@yanbingtao yanbingtao linked an issue Oct 21, 2020 that may be closed by this pull request
Implement Sales Storage #95
Closed
Persdre
Persdre approved these changes Oct 21, 2020
View reviewed changes
Copy link

@Persdre Persdre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WM71811
WM71811 approved these changes Oct 21, 2020
View reviewed changes
Copy link

@WM71811 WM71811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WM71811 WM71811 merged commit 36aa41f into master Oct 21, 2020
@yanbingtao yanbingtao changed the title Implements Sales Storage feature Implement Sales Storage feature Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Persdre Persdre Persdre approved these changes

@WM71811 WM71811 WM71811 approved these changes

Assignees

@yanbingtao yanbingtao

Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Implement Sales Storage
3 participants
@yanbingtao @Persdre @WM71811