forked from nus-cs2103-AY2021S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge conversion-to-flashcards into master #71
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-to-flashcards Delete Address Class
…1-CS2103T-T15-2/tp into conversion-to-flashcards
Remove all associated production and test code.
…on-to-flashcards Conversion to flashcards: Delete Email class
…e-to-question Conversion to flashcards: Convert name class to question class
Convert Phone class to Answer class
…cards Conversion to flashcards Fork Update
Utilized refactoring, with some minor checkstyle fixes.
Utilize IntelliJ refactoring to rename Person class to Flashcard class within Model component. - Includes minor Checkstyle fixes. - Rename TypicalPersons to TypicalFlashcards - Rename PersonUtil to FlashcardUtil - Rename JsonAdaptedPersonTest to JsonAdaptedFlashcardTest - Rename UniquePersonListTest to UniqueFlashcardListTest - Rename PersonTest to FlashcardTest - Rename EditPersonDescriptorTest to EditFlashcardDescriptorTest.
Utilize IntelliJ refactor renaming function.
….2-convert-Person-to-Flashcard Conversion: Person class to Flashcard class
…1-CS2103T-T15-2/tp into test-flashcard-conversion-pr * 'conversion-to-flashcards' of https://github.com/AY2021S1-CS2103T-T15-2/tp: Update FlashcardListCard.fxml
…into test-flashcard-conversion-pr * 'master' of https://github.com/AY2021S1-CS2103T-T15-2/tp: Minor document grammar tweaks Update UG Added newline to AboutUs AboutUs: Rename to github username Update AboutUs with personal details
…on-to-flashcards Convert all addressbook references into Flash Notes
…t-validation Remove input validation
…on-to-flashcards Add a Command to list cards by Tags
chuyouchia
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.