Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge conversion-to-flashcards into master #71

Closed
wants to merge 63 commits into from

Conversation

pengxiangg
Copy link
Collaborator

No description provided.

pengxiangg and others added 30 commits September 21, 2020 14:52
Remove all associated production and test code.
…on-to-flashcards

Conversion to flashcards: Delete Email class
…e-to-question

Conversion to flashcards: Convert name class to question class
…cards

Conversion to flashcards Fork Update
Utilized refactoring, with some minor checkstyle fixes.
Utilize IntelliJ refactoring to rename Person class to 
Flashcard class within Model component.

- Includes minor Checkstyle fixes.
- Rename TypicalPersons to TypicalFlashcards
- Rename PersonUtil to FlashcardUtil
- Rename JsonAdaptedPersonTest to JsonAdaptedFlashcardTest
- Rename UniquePersonListTest to UniqueFlashcardListTest
- Rename PersonTest to FlashcardTest
- Rename EditPersonDescriptorTest to EditFlashcardDescriptorTest.
Fixes Flashcards list not displaying anything.
Utilize IntelliJ refactor renaming function.
pengxiangg and others added 24 commits September 25, 2020 23:40
….2-convert-Person-to-Flashcard

Conversion: Person class to Flashcard class
…1-CS2103T-T15-2/tp into test-flashcard-conversion-pr

* 'conversion-to-flashcards' of https://github.com/AY2021S1-CS2103T-T15-2/tp:
  Update FlashcardListCard.fxml
…into test-flashcard-conversion-pr

* 'master' of https://github.com/AY2021S1-CS2103T-T15-2/tp:
  Minor document grammar tweaks
  Update UG
  Added newline to AboutUs
  AboutUs: Rename to github username
  Update AboutUs with personal details
…on-to-flashcards

Convert all addressbook references into Flash Notes
…on-to-flashcards

Add a Command to list cards by Tags
@pengxiangg pengxiangg added this to the v1.2 milestone Oct 5, 2020
@pengxiangg pengxiangg linked an issue Oct 5, 2020 that may be closed by this pull request
Copy link

@chuyouchia chuyouchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengxiangg pengxiangg closed this Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge conversion branch into master
5 participants