Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ug dg and some code and javadocs #409

Merged
merged 33 commits into from
Nov 8, 2020
Merged

Update ug dg and some code and javadocs #409

merged 33 commits into from
Nov 8, 2020

Conversation

seanjyjy
Copy link

@seanjyjy seanjyjy commented Nov 7, 2020 •
edited

Address #401

Pr Overview

  • Remove CardTest as unable to ensure the test accuracy. The thread seems to allow any test case to pass.
  • Update UG Header
  • Update DG manual testing to fit with sample data
  • Update version to v1.3.1 (will update to v1.4 by tonight for our release)
  • Fix up javadocs
  • Beef up edit company and edit profile test
  • Beef up profile item test

@seanjyjy seanjyjy added this to the v1.4 milestone Nov 7, 2020
@seanjyjy seanjyjy requested review from shawn-nyk and a team November 7, 2020 18:40
shawn-nyk
shawn-nyk reviewed Nov 7, 2020
View reviewed changes
Copy link

@shawn-nyk shawn-nyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just one small question and we're good to merge.

docs/UserGuide.md Outdated Show resolved Hide resolved
@seanjyjy seanjyjy self-assigned this Nov 8, 2020
keanecjy
keanecjy approved these changes Nov 8, 2020
View reviewed changes
Copy link

@keanecjy keanecjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keanecjy keanecjy merged commit 2dcc3b0 into AY2021S1-CS2103T-T15-4:master Nov 8, 2020
@seanjyjy seanjyjy changed the title Update ug dg and some code Update ug dg and some code and javadocs Nov 8, 2020
@seanjyjy seanjyjy mentioned this pull request Nov 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawn-nyk shawn-nyk shawn-nyk left review comments

@keanecjy keanecjy keanecjy approved these changes

Assignees

@seanjyjy seanjyjy

Labels
Code Developer Guide User guide
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seanjyjy @keanecjy @shawn-nyk