Add Appointment tests #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
============================================
+ Coverage 63.89% 65.24% +1.35%
- Complexity 404 413 +9
============================================
Files 86 86
Lines 1407 1407
Branches 142 142
============================================
+ Hits 899 918 +19
+ Misses 471 448 -23
- Partials 37 41 +4
Continue to review full report at Codecov.
|
jianhandev
reviewed
Oct 13, 2020
Comment on lines
22
to
34
| private final LocalDateTime dateTimeOne = LocalDateTime.parse("2020-10-11T12:45:30"); | ||
| private final LocalDateTime dateTimeTwo = LocalDateTime.parse("2002-11-11T11:30:20"); | ||
| private final Description description = new Description("long term patient"); | ||
| private final Set<Tag> tagSet = new HashSet<>(); | ||
|
|
||
| private final Appointment apt1 = new Appointment(ALICE, dateTimeOne, tagSet, description, | ||
| AppointmentStatus.DONE); | ||
| private final Appointment apt2 = new Appointment(BOB, dateTimeOne, tagSet, description, | ||
| AppointmentStatus.UPCOMING); | ||
| private final Appointment apt3 = new Appointment(CARL, dateTimeTwo, tagSet, description, | ||
| AppointmentStatus.DONE); | ||
| private final Appointment apt4 = new Appointment(ALICE, dateTimeTwo, tagSet, description, | ||
| AppointmentStatus.UPCOMING); |
There was a problem hiding this comment.
can be moved to a separate util class e.g. TypicalAppointments class
Comment on lines
56
to
59
| assertEquals(apt4, apt1); | ||
| // different Patient -> False | ||
| assertNotEquals(apt2, apt1); | ||
|
|
There was a problem hiding this comment.
can do likewise for description, datetime, status, tags
There was a problem hiding this comment.
we will need an AppointmentBuilder class too
| public static final Appointment APT2 = new Appointment(BOB, LocalDateTime.parse("2020-10-11T12:45:30"), | ||
| new HashSet<>(), new Description("long term patient"), AppointmentStatus.UPCOMING); | ||
|
|
||
| public static final Appointment APT3 = new Appointment(CARL, LocalDateTime.parse("2002-11-11T11:30:20"), |
There was a problem hiding this comment.
LocalDateTime will have to be updated to use custom DateTime class. Refer to the latest commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some tests for Appointment.