Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Revenue Feature #194

Merged

Conversation

galvinleow
Copy link

Default sort by date and sort by value command

Default sort by date and sort by value command
@galvinleow galvinleow added type.Enhancement An enhancement to an existing story priority.High Must do hacktoberfest-accepted labels Oct 23, 2020
@galvinleow galvinleow added this to the v1.3 milestone Oct 23, 2020
@galvinleow galvinleow self-assigned this Oct 23, 2020
@galvinleow galvinleow linked an issue Oct 23, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #194 into master will decrease coverage by 0.22%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #194      +/-   ##
============================================
- Coverage     32.70%   32.48%   -0.23%     
  Complexity      512      512              
============================================
  Files           193      197       +4     
  Lines          3611     3636      +25     
  Branches        424      425       +1     
============================================
  Hits           1181     1181              
- Misses         2382     2407      +25     
  Partials         48       48              
Impacted Files Coverage Δ Complexity Δ
...rce/logic/commands/revenue/ListRevenueCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rce/logic/commands/revenue/SortRevenueCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/seedu/homerce/logic/parser/HomerceParser.java 34.09% <0.00%> (-0.80%) 11.00 <0.00> (ø)
...in/java/seedu/homerce/logic/parser/ParserUtil.java 28.57% <0.00%> (ø) 12.00 <0.00> (ø)
...logic/parser/revenue/SortRevenueCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...rc/main/java/seedu/homerce/model/ModelManager.java 47.61% <ø> (ø) 29.00 <0.00> (ø)
...va/seedu/homerce/model/manager/RevenueTracker.java 48.57% <0.00%> (-4.56%) 6.00 <0.00> (ø)
...seedu/homerce/model/revenue/RevenueComparator.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...omerce/model/revenue/RevenueDefaultComparator.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7f2242...2f8ebcc. Read the comment docs.

Copy link

@hanstirtaputra hanstirtaputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanstirtaputra hanstirtaputra merged commit 3987cda into AY2021S1-CS2103T-W13-3:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted priority.High Must do type.Enhancement An enhancement to an existing story
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort Feature for Revenue
3 participants