-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add calculations of budget and savings #172
Add calculations of budget and savings #172
Conversation
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
============================================
- Coverage 76.03% 75.51% -0.53%
- Complexity 771 787 +16
============================================
Files 131 129 -2
Lines 2270 2381 +111
Branches 243 252 +9
============================================
+ Hits 1726 1798 +72
- Misses 447 488 +41
+ Partials 97 95 -2
Continue to review full report at Codecov.
|
f97ac04
to
e7a4e7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addition of expenses does not affect the remaining budget.
334359b
to
3456f19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Resolves #170.
Resolves #171.
Changes:
ObservableAmount
is no longer abstract to avoid duplication of similar classesMonthlyBudget
; these values are not stored in the finance tracker but are calculated whenever the amounts in the finance tracker's transactions changes.CommandResult
to track when the budget information inMonthlyBudget
needs to be recalculated.assertCommandSuccess
to pass tests; likely a temporary fix, will try to think of something better down the line.SavingsGoalPanel
for easy reference for now.