Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UI resizable #174

Merged
merged 9 commits into from
Oct 24, 2020
Merged

Make UI resizable #174

merged 9 commits into from
Oct 24, 2020

Conversation

ianyong
Copy link
Member

@ianyong ianyong commented Oct 24, 2020

Changes:

  • Enable resizing of application window.
  • Set minimum window size of 900 by 650.
  • Update UI components to be resizable.
    • Tabs are now anchored to the top of the window, while the result display box and command line are anchored to the bottom. The contents of the tab resize freely to fill empty space.
    • On the Overview, Incomes, and Expenses tabs, the main panel and side panel are fixed to a 3:2 ratio.
  • Update application to keep track of window fullscreen status across sessions.
    • If the application was closed while fullscreen previously, it will launch in fullscreen.
    • Window size and position are captured whenever the window is moved or resized while not fullscreen.
      • This is to allow for proper exiting out of fullscreen mode across sessions.
  • Add text wrap to the result display box.
  • Use 2 spaces per indentation instead of 4 for fxml files.

Note that the savings goal panel has an image that still has a hardcoded size. This has not been fixed due to @zhaojj2209 making changes to it in #172 as well.

Resolves #162.

@ianyong ianyong added type.enhancement 👍 New feature or request priority.medium 🥈 Todo for current iteration labels Oct 24, 2020
@ianyong ianyong added this to the v1.3 milestone Oct 24, 2020
@ianyong ianyong requested a review from a team October 24, 2020 18:42
zhaojj2209
zhaojj2209 previously approved these changes Oct 24, 2020
Copy link

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-io
Copy link

Codecov Report

Merging #174 into master will decrease coverage by 0.73%.
The diff coverage is 16.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #174      +/-   ##
============================================
- Coverage     75.51%   74.78%   -0.74%     
  Complexity      787      787              
============================================
  Files           129      129              
  Lines          2381     2407      +26     
  Branches        252      253       +1     
============================================
+ Hits           1798     1800       +2     
- Misses          488      511      +23     
- Partials         95       96       +1     
Impacted Files Coverage Δ Complexity Δ
...a/ay2021s1_cs2103_w16_3/finesse/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/ay2021s1_cs2103_w16_3/finesse/ui/UiManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...cs2103_w16_3/finesse/commons/core/GuiSettings.java 70.00% <70.00%> (-3.08%) 6.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7fbd22...624010c. Read the comment docs.

Copy link

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@yongping827 yongping827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongping827 yongping827 merged commit 6f98875 into master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.medium 🥈 Todo for current iteration type.enhancement 👍 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make UI resizable
4 participants