Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update storage and common classes DG #60

Closed
wants to merge 13 commits into from
Closed

Update storage and common classes DG #60

wants to merge 13 commits into from

Conversation

Royxuzeng
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 20, 2020 •
edited

Codecov Report

Merging #60 into master will increase coverage by 1.67%.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #60      +/-   ##
============================================
+ Coverage     58.48%   60.16%   +1.67%     
- Complexity      506      513       +7     
============================================
  Files           100      100              
  Lines          1932     1928       -4     
  Branches        197      197              
============================================
+ Hits           1130     1160      +30     
+ Misses          723      677      -46     
- Partials         79       91      +12
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/ExerciseMainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/seedu/address/logic/LogicManagerForExercise.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../address/logic/commands/AddCommandForExercise.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../main/java/seedu/address/ui/ExerciseListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../main/java/seedu/address/ui/ExerciseUiManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...n/java/seedu/address/ui/MainWindowForExercise.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...java/seedu/address/model/exercise/Description.java 70.00% <100.00%> (+3.33%) 6.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 50.00% <0.00%> (-42.31%) 3.00% <0.00%> (-8.00%)
.../address/logic/commands/UpdateExerciseCommand.java 85.71% <0.00%> (+1.58%) 12.00% <0.00%> (ø%)
...seedu/address/logic/parser/ExerciseBookParser.java 53.33% <0.00%> (+6.66%) 5.00% <0.00%> (+1.00%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 417b7f3...ec6ef97. Read the comment docs.

leeweiminsg
leeweiminsg reviewed Oct 21, 2020
View reviewed changes
docs/DeveloperGuide.md Outdated
@@ -115,7 +115,7 @@ The `Model`,

### Storage component

![Structure of the Storage Component](images/StorageClassDiagram.png)
![Structure of the Storage Component](images/StorageClassDiagram2.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe another name?

Eg. ExerciseStorageClassDiagram

@Nahoyhp
Copy link

Nahoyhp commented Oct 26, 2020

Make PR to v1.3 Branch. Closing.

@Nahoyhp Nahoyhp closed this Oct 26, 2020
@Nahoyhp Nahoyhp mentioned this pull request Oct 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeweiminsg leeweiminsg leeweiminsg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Royxuzeng @codecov-io @Nahoyhp @leeweiminsg @Nauman-S