Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classes for Assignment and AddAssignmentCommand #82

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

uyencfi
Copy link

@uyencfi uyencfi commented Oct 12, 2021

  • Assignment class implementation
  • Assignments are stored under Module, in a UniqueAssignmentList object

Person, Assignment and Module all have an field for name. Let's move the existing Name class to its own package to be used by all Person, Assignment and Module.
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #82 (d4dc9ff) into master (0fb1d44) will decrease coverage by 4.22%.
The diff coverage is 10.74%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #82      +/-   ##
============================================
- Coverage     67.40%   63.17%   -4.23%     
- Complexity      454      455       +1     
============================================
  Files            83       90       +7     
  Lines          1500     1613     +113     
  Branches        156      174      +18     
============================================
+ Hits           1011     1019       +8     
- Misses          447      552     +105     
  Partials         42       42              
Impacted Files Coverage Δ
.../edrecord/logic/commands/AddAssignmentCommand.java 0.00% <0.00%> (ø)
...ava/seedu/edrecord/logic/commands/EditCommand.java 95.94% <ø> (ø)
.../seedu/edrecord/logic/parser/AddCommandParser.java 100.00% <ø> (ø)
...n/java/seedu/edrecord/logic/parser/ParserUtil.java 83.33% <ø> (ø)
src/main/java/seedu/edrecord/model/Model.java 100.00% <ø> (ø)
...va/seedu/edrecord/model/assignment/Assignment.java 0.00% <0.00%> (ø)
...java/seedu/edrecord/model/assignment/MaxScore.java 0.00% <0.00%> (ø)
...ava/seedu/edrecord/model/assignment/Weightage.java 0.00% <0.00%> (ø)
...gnment/exceptions/AssignmentNotFoundException.java 0.00% <0.00%> (ø)
...nment/exceptions/DuplicateAssignmentException.java 0.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb1d44...d4dc9ff. Read the comment docs.

Copy link

@marcusc55 marcusc55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caipng caipng added this to the v1.2 milestone Oct 12, 2021
Copy link

@caipng caipng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the requested changes, LGTM.

Co-authored-by: caipng <67316767+caipng@users.noreply.github.com>
@uyencfi uyencfi requested a review from caipng October 13, 2021 03:24
@marcusc55 marcusc55 added the v1.2 label Oct 13, 2021
Copy link

@caipng caipng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caipng caipng merged commit 1f8a85a into AY2122S1-CS2103-W14-3:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants