-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add classes for Assignment and AddAssignmentCommand #82
Conversation
uyencfi
commented
Oct 12, 2021
- Assignment class implementation
- Assignments are stored under Module, in a UniqueAssignmentList object
Person, Assignment and Module all have an field for name. Let's move the existing Name class to its own package to be used by all Person, Assignment and Module.
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
============================================
- Coverage 67.40% 63.17% -4.23%
- Complexity 454 455 +1
============================================
Files 83 90 +7
Lines 1500 1613 +113
Branches 156 174 +18
============================================
+ Hits 1011 1019 +8
- Misses 447 552 +105
Partials 42 42
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the requested changes, LGTM.
src/main/java/seedu/edrecord/model/assignment/UniqueAssignmentList.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/edrecord/model/assignment/UniqueAssignmentList.java
Outdated
Show resolved
Hide resolved
Co-authored-by: caipng <67316767+caipng@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM