-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add class groups #92
Add class groups #92
Conversation
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
============================================
- Coverage 62.27% 60.86% -1.42%
- Complexity 458 507 +49
============================================
Files 92 100 +8
Lines 1654 1855 +201
Branches 179 216 +37
============================================
+ Hits 1030 1129 +99
- Misses 582 661 +79
- Partials 42 65 +23
Continue to review full report at Codecov.
|
There's no checks to create a person to an existing class for now Sample test case:
If we're rushing, we can shift this to another issue in 1.3 |
@FergusMok These test cases are all under Add..Test or Edit..Test already but I didn't have to change them because the TypicalModules and PersonBuilder takes class into consideration already. However I haven't added test cases for making mods and class I'll put those under v1.3 for now since I might not be able to rush them out yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@chaiwanlin Sorry I meant non-existing class, I think it's a non-intended bug. I think test cases not super impt for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits.
src/test/java/seedu/edrecord/logic/commands/EditCommandTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
closes #25