Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvement Cont. #200

Conversation

Timothyoung97
Copy link
Member

No description provided.

@Timothyoung97 Timothyoung97 added type.Task Something that needs to be done, but not a story, bug, or an epic priority.Medium Nice to have labels Oct 26, 2021
@Timothyoung97 Timothyoung97 added this to the v1.3 milestone Oct 26, 2021
@Timothyoung97 Timothyoung97 self-assigned this Oct 26, 2021
@Timothyoung97 Timothyoung97 marked this pull request as ready for review October 26, 2021 20:57
@Timothyoung97
Copy link
Member Author

Minor Checks on UI

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #200 (f51a218) into master (7dc42c0) will increase coverage by 0.60%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #200      +/-   ##
============================================
+ Coverage     75.42%   76.02%   +0.60%     
- Complexity      699      705       +6     
============================================
  Files           100      100              
  Lines          2083     2106      +23     
  Branches        268      268              
============================================
+ Hits           1571     1601      +30     
+ Misses          443      439       -4     
+ Partials         69       66       -3     
Impacted Files Coverage Δ
src/main/java/seedu/tuitione/ui/StudentCard.java 0.00% <0.00%> (ø)
...ava/seedu/tuitione/logic/commands/FindCommand.java 100.00% <0.00%> (ø)
...a/seedu/tuitione/logic/commands/EnrollCommand.java 94.11% <0.00%> (ø)
...a/seedu/tuitione/logic/commands/RosterCommand.java 0.00% <0.00%> (ø)
src/main/java/seedu/tuitione/model/Tuitione.java 93.47% <0.00%> (+0.79%) ⬆️
...c/main/java/seedu/tuitione/logic/LogicManager.java 72.72% <0.00%> (+1.29%) ⬆️
...n/java/seedu/tuitione/logic/parser/ParserUtil.java 96.59% <0.00%> (+2.27%) ⬆️
.../main/java/seedu/tuitione/model/lesson/Lesson.java 87.65% <0.00%> (+2.46%) ⬆️
...c/main/java/seedu/tuitione/model/ModelManager.java 81.72% <0.00%> (+2.70%) ⬆️
...ain/java/seedu/tuitione/model/student/Student.java 78.20% <0.00%> (+3.84%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc42c0...f51a218. Read the comment docs.

@Timothyoung97
Copy link
Member Author

Timothyoung97 commented Oct 27, 2021

Theme change done

Paperlike

image

@Timothyoung97 Timothyoung97 requested a review from a team October 27, 2021 08:10
Copy link

@michael-lee-sk michael-lee-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim for changing the theme of our UI! Looks much neater and friendlier now 👯 👍

…nch-UI-Improvement-Round-2

# Conflicts:
#	src/main/resources/view/LessonListCard.fxml
@Timothyoung97 Timothyoung97 merged commit f56fadc into AY2122S1-CS2103T-F13-4:master Oct 27, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have type.Task Something that needs to be done, but not a story, bug, or an epic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants