Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear -f command to User Guide and fix typos #236

Merged
merged 13 commits into from
Apr 6, 2022

Conversation

jamesyeap
Copy link

@jamesyeap jamesyeap commented Apr 3, 2022

Fixes #223
Fixes #232
Fixes #212

This pull-request adds

  • a description of the clear -f command to the User Guide
  • edits to the findstudents and findlessonssections of the User Guide
  • a draft of the PPP for James

@jamesyeap jamesyeap added the documentation Improvements or additions to documentation label Apr 3, 2022
@jamesyeap jamesyeap added this to the V1.4 milestone Apr 3, 2022
@jamesyeap jamesyeap requested a review from a team April 3, 2022 10:24
@jamesyeap jamesyeap self-assigned this Apr 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2022

Codecov Report

Merging #236 (64edb4b) into master (c6b80c7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #236   +/-   ##
=========================================
  Coverage     48.17%   48.17%           
  Complexity      594      594           
=========================================
  Files           125      125           
  Lines          2788     2788           
  Branches        305      305           
=========================================
  Hits           1343     1343           
  Misses         1352     1352           
  Partials         93       93           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b80c7...64edb4b. Read the comment docs.

@jamesyeap jamesyeap changed the title Add clear -f command to User Guide Add clear -f command to User Guide and fix typos Apr 4, 2022
@jamesyeap jamesyeap marked this pull request as draft April 5, 2022 08:25
@jamesyeap jamesyeap marked this pull request as ready for review April 5, 2022 09:13
Copy link

@nnmoq nnmoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should split this into multiple PRs next time.

@jamesyeap jamesyeap merged commit a4d95dc into AY2122S2-CS2103T-W11-3:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] Grammar mistakes [PE-D] UG no Clear command [PE-D] Optional inputs in command format
3 participants