Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DateParser class #136

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

seetohjinwei
Copy link

@seetohjinwei seetohjinwei commented Oct 13, 2022

Fixes #35

@seetohjinwei seetohjinwei self-assigned this Oct 13, 2022
@seetohjinwei seetohjinwei added this to the v1.3 milestone Oct 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #136 (5393f48) into master (98de953) will decrease coverage by 0.31%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #136      +/-   ##
============================================
- Coverage     68.46%   68.14%   -0.32%     
  Complexity      474      474              
============================================
  Files            87       88       +1     
  Lines          1538     1554      +16     
  Branches        178      177       -1     
============================================
+ Hits           1053     1059       +6     
- Misses          425      436      +11     
+ Partials         60       59       -1     
Impacted Files Coverage Δ
src/main/java/taskbook/commons/core/Messages.java 0.00% <ø> (ø)
...rc/main/java/taskbook/logic/parser/DateParser.java 0.00% <0.00%> (ø)
...rc/main/java/taskbook/storage/JsonAdaptedTask.java 55.17% <0.00%> (+2.04%) ⬆️
src/main/java/taskbook/model/task/Task.java 59.52% <0.00%> (+8.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@xiaobill8 xiaobill8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@dexter-sim dexter-sim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dexter-sim dexter-sim merged commit cbeff84 into AY2223S1-CS2103T-T13-4:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user, I can use my preferred date format in commands
4 participants