Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random bugs #262

Merged
merged 2 commits into from
Nov 6, 2022
Merged

Fix random bugs #262

merged 2 commits into from
Nov 6, 2022

Conversation

@kevinchangjk kevinchangjk added priority.Medium Important / urgent type.Documentation Improvements or additions to documentation type.Bug Something isn't working labels Nov 6, 2022
@kevinchangjk kevinchangjk added this to the v1.4 milestone Nov 6, 2022
@kevinchangjk kevinchangjk self-assigned this Nov 6, 2022
@kevinchangjk kevinchangjk requested review from prit3010 and removed request for chao890 November 6, 2022 16:00
Copy link

@prit3010 prit3010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Merging #262 (6cb374c) into master (270492e) will not change coverage.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##             master     #262   +/-   ##
=========================================
  Coverage     65.21%   65.21%           
  Complexity      604      604           
=========================================
  Files            93       93           
  Lines          2199     2199           
  Branches        271      271           
=========================================
  Hits           1434     1434           
  Misses          687      687           
  Partials         78       78           
Impacted Files Coverage Δ
src/main/java/coydir/commons/core/Messages.java 0.00% <ø> (ø)
...c/main/java/coydir/logic/commands/ViewCommand.java 0.00% <0.00%> (ø)
...in/java/coydir/logic/commands/AddLeaveCommand.java 100.00% <100.00%> (ø)
...main/java/coydir/logic/commands/DeleteCommand.java 100.00% <100.00%> (ø)
...java/coydir/logic/commands/DeleteLeaveCommand.java 80.00% <100.00%> (ø)
...c/main/java/coydir/logic/commands/EditCommand.java 95.87% <100.00%> (ø)
...c/main/java/coydir/logic/commands/RateCommand.java 92.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chao890
Copy link

chao890 commented Nov 6, 2022

Lousy. Merge approved.

@chao890 chao890 merged commit f7c448c into master Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment